-
Notifications
You must be signed in to change notification settings - Fork 1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Filter out feature sets that dont share the same source (#339)
* Filter out feature sets that dont share the same source * Apply spotless * Change typo
- Loading branch information
1 parent
3b4dcaa
commit e8d1b01
Showing
2 changed files
with
167 additions
and
19 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
153 changes: 153 additions & 0 deletions
153
core/src/test/java/feast/core/grpc/CoreServiceImplTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,153 @@ | ||
| /* | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| * Copyright 2018-2019 The Feast Authors | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package feast.core.grpc; | ||
|
|
||
| import static org.hamcrest.Matchers.containsInAnyOrder; | ||
| import static org.junit.Assert.*; | ||
| import static org.mockito.ArgumentMatchers.eq; | ||
| import static org.mockito.Mockito.times; | ||
| import static org.mockito.Mockito.verify; | ||
| import static org.mockito.Mockito.when; | ||
| import static org.mockito.MockitoAnnotations.initMocks; | ||
|
|
||
| import com.google.protobuf.InvalidProtocolBufferException; | ||
| import feast.core.CoreServiceProto.ApplyFeatureSetRequest; | ||
| import feast.core.CoreServiceProto.ApplyFeatureSetResponse; | ||
| import feast.core.CoreServiceProto.ApplyFeatureSetResponse.Status; | ||
| import feast.core.CoreServiceProto.ListFeatureSetsRequest; | ||
| import feast.core.CoreServiceProto.ListFeatureSetsResponse; | ||
| import feast.core.CoreServiceProto.ListStoresResponse; | ||
| import feast.core.FeatureSetProto.FeatureSetSpec; | ||
| import feast.core.SourceProto.KafkaSourceConfig; | ||
| import feast.core.SourceProto.Source; | ||
| import feast.core.SourceProto.SourceType; | ||
| import feast.core.StoreProto.Store; | ||
| import feast.core.StoreProto.Store.RedisConfig; | ||
| import feast.core.StoreProto.Store.StoreType; | ||
| import feast.core.StoreProto.Store.Subscription; | ||
| import feast.core.service.JobCoordinatorService; | ||
| import feast.core.service.SpecService; | ||
| import io.grpc.stub.StreamObserver; | ||
| import java.util.ArrayList; | ||
| import org.junit.Before; | ||
| import org.junit.Test; | ||
| import org.mockito.ArgumentCaptor; | ||
| import org.mockito.ArgumentMatchers; | ||
| import org.mockito.Captor; | ||
| import org.mockito.Mock; | ||
|
|
||
| public class CoreServiceImplTest { | ||
|
|
||
| @Mock private JobCoordinatorService jobCoordinatorService; | ||
|
|
||
| @Mock private SpecService specService; | ||
|
|
||
| @Captor private ArgumentCaptor<ArrayList<FeatureSetSpec>> fsListArgCaptor; | ||
|
|
||
| @Before | ||
| public void setUp() { | ||
| initMocks(this); | ||
| } | ||
|
|
||
| @Test | ||
| public void shouldPassCorrectListOfFeatureSetsToJobService() | ||
| throws InvalidProtocolBufferException { | ||
| CoreServiceImpl coreService = new CoreServiceImpl(specService, jobCoordinatorService); | ||
| Store store = | ||
| Store.newBuilder() | ||
| .setType(StoreType.REDIS) | ||
| .setRedisConfig(RedisConfig.newBuilder().setHost("localhost").setPort(6379).build()) | ||
| .addSubscriptions(Subscription.newBuilder().setName("*").setVersion(">0")) | ||
| .build(); | ||
| FeatureSetSpec fs1Sc1 = | ||
| FeatureSetSpec.newBuilder() | ||
| .setName("feature_set") | ||
| .setVersion(1) | ||
| .setSource( | ||
| Source.newBuilder() | ||
| .setType(SourceType.KAFKA) | ||
| .setKafkaSourceConfig( | ||
| KafkaSourceConfig.newBuilder() | ||
| .setBootstrapServers("kafka:9092") | ||
| .setTopic("topic1") | ||
| .build())) | ||
| .build(); | ||
| FeatureSetSpec fs2Sc1 = | ||
| FeatureSetSpec.newBuilder() | ||
| .setName("feature_set_other") | ||
| .setVersion(1) | ||
| .setSource( | ||
| Source.newBuilder() | ||
| .setType(SourceType.KAFKA) | ||
| .setKafkaSourceConfig( | ||
| KafkaSourceConfig.newBuilder() | ||
| .setBootstrapServers("kafka:9092") | ||
| .setTopic("topic1") | ||
| .build())) | ||
| .build(); | ||
| FeatureSetSpec fs3Sc2 = | ||
| FeatureSetSpec.newBuilder() | ||
| .setName("feature_set") | ||
| .setVersion(2) | ||
| .setSource( | ||
| Source.newBuilder() | ||
| .setType(SourceType.KAFKA) | ||
| .setKafkaSourceConfig( | ||
| KafkaSourceConfig.newBuilder() | ||
| .setBootstrapServers("kafka:9092") | ||
| .setTopic("topic2") | ||
| .build())) | ||
| .build(); | ||
| when(specService.applyFeatureSet(fs1Sc1)) | ||
| .thenReturn( | ||
| ApplyFeatureSetResponse.newBuilder() | ||
| .setStatus(Status.CREATED) | ||
| .setFeatureSet(fs1Sc1) | ||
| .build()); | ||
| when(specService.listStores(ArgumentMatchers.any())) | ||
| .thenReturn(ListStoresResponse.newBuilder().addStore(store).build()); | ||
| when(specService.listFeatureSets( | ||
| ListFeatureSetsRequest.Filter.newBuilder() | ||
| .setFeatureSetName("*") | ||
| .setFeatureSetVersion(">0") | ||
| .build())) | ||
| .thenReturn( | ||
| ListFeatureSetsResponse.newBuilder() | ||
| .addFeatureSets(fs1Sc1) | ||
| .addFeatureSets(fs3Sc2) | ||
| .addFeatureSets(fs2Sc1) | ||
| .build()); | ||
|
|
||
| coreService.applyFeatureSet( | ||
| ApplyFeatureSetRequest.newBuilder().setFeatureSet(fs1Sc1).build(), | ||
| new StreamObserver<ApplyFeatureSetResponse>() { | ||
| @Override | ||
| public void onNext(ApplyFeatureSetResponse applyFeatureSetResponse) {} | ||
|
|
||
| @Override | ||
| public void onError(Throwable throwable) {} | ||
|
|
||
| @Override | ||
| public void onCompleted() {} | ||
| }); | ||
|
|
||
| verify(jobCoordinatorService, times(1)) | ||
| .startOrUpdateJob(fsListArgCaptor.capture(), eq(fs1Sc1.getSource()), eq(store)); | ||
|
|
||
| assertThat(fsListArgCaptor.getValue(), containsInAnyOrder(fs1Sc1, fs2Sc1)); | ||
| } | ||
| } |