Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to scala.js 1.x #55

Merged
merged 2 commits into from
Jun 25, 2020
Merged

Update to scala.js 1.x #55

merged 2 commits into from
Jun 25, 2020

Conversation

busti
Copy link
Collaborator

@busti busti commented Jun 23, 2020

I am not certain if it will work like this...
But there is no example of this in the jitpack docs

.jitpack.yml Outdated Show resolved Hide resolved
@busti
Copy link
Collaborator Author

busti commented Jun 23, 2020

I have applied the change and squashed the two commits

.jitpack.yml Outdated Show resolved Hide resolved
@busti
Copy link
Collaborator Author

busti commented Jun 24, 2020

Sorry about that, my bash knowledge is a little rusty.
There also seems to be an error when downloading sbt-launcher, so I will try to get that fixed in this pr as well.

@busti
Copy link
Collaborator Author

busti commented Jun 24, 2020

Sorry for the spam. Everything should be in order now.
This PR now depends on fdietze/bench#20 which at this point is already merged.

This now also includes the following changes:

  • updated maven central url
  • updated scalatestplus to a version supporting scala.js 1.x
  • updated bench to a version supporting scala.js 1.x

Quick note: The build log with output an error when running the second command. This is due to the jvm artifacts already being present. Unfortunately this error cannot be silenced due to sbt/sbt-pgp#124 . However, this does not cause any issues, the extra artifacts are discarded.

@busti
Copy link
Collaborator Author

busti commented Jun 24, 2020

The travis build failed with the following error:

[error] (benchJS / Test / scalaJSIR) org.scalajs.core.ir.IRVersionNotSupportedException: Failed to deserialize info of file compiled with Scala.js 1.0 (supported: 0.6.0, 0.6.13, 0.6.3, 0.6.17, 0.6.4, 0.6.6, 0.6.14, 0.6.8, 0.6.30, 0.6.29, 0.6.5, 0.6.15): /home/travis/.coursier/cache/v1/https/jitpack.io/com/github/fdietze/bench/bench_sjs0.6_2.11/5ffab44/bench_sjs0.6_2.11-5ffab44.jar:bench/util/package.sjsir

This is a problem in bench, but I do not have the slightest idea what could be causing it. The filename suggests that it was compiled with scala.js 0.6.x, but in the message it says that it was compiled with 1.0.
Maybe upgrading bench to 1.1 fixes this?

@fdietze
Copy link
Owner

fdietze commented Jun 25, 2020

I'm also fine with dropping 0.6 completely and only keeping scalajs 1.0. That would make things easier, I guess.

@busti
Copy link
Collaborator Author

busti commented Jun 25, 2020

@fdietze Sounds good, should I add that to this PR?

@fdietze
Copy link
Owner

fdietze commented Jun 25, 2020

@busti absolutely!

@busti busti changed the title build the project twice, for each scalajs version Update to scala.js 1.x Jun 25, 2020
@busti
Copy link
Collaborator Author

busti commented Jun 25, 2020

@fdietze it is done

@fdietze
Copy link
Owner

fdietze commented Jun 25, 2020

@busti Thank you! I just gave you the permission to merge yourself.

@busti
Copy link
Collaborator Author

busti commented Jun 25, 2020

I suppose that's a solution. Consider it merged!

@busti busti merged commit 4f51de0 into fdietze:master Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants