-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to scala.js 1.x #55
Conversation
I have applied the change and squashed the two commits |
Sorry about that, my bash knowledge is a little rusty. |
Sorry for the spam. Everything should be in order now. This now also includes the following changes:
Quick note: The build log with output an error when running the second command. This is due to the jvm artifacts already being present. Unfortunately this error cannot be silenced due to sbt/sbt-pgp#124 . However, this does not cause any issues, the extra artifacts are discarded. |
The travis build failed with the following error:
This is a problem in bench, but I do not have the slightest idea what could be causing it. The filename suggests that it was compiled with |
I'm also fine with dropping |
@fdietze Sounds good, should I add that to this PR? |
@busti absolutely! |
@fdietze it is done |
@busti Thank you! I just gave you the permission to merge yourself. |
I suppose that's a solution. Consider it merged! |
I am not certain if it will work like this...
But there is no example of this in the jitpack docs