Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade metacolon dependency #99

Closed
wants to merge 1 commit into from
Closed

Upgrade metacolon dependency #99

wants to merge 1 commit into from

Conversation

FND
Copy link
Collaborator

@FND FND commented Jan 16, 2025

I'm afraid I imposed a few breaking changes upon us, for no good reason:

  • requires Node v22 (for iterator helpers, mostly)
  • whitespace trimming is now much more limited

The latter explains the failing tests, but I'm currently unsure how best to fix this...

@moonglum
Copy link
Member

Not super happy to bump a faucet-pipeline package all the way up to 22, but I think it is okay for aiur. Thanks for checking in here 🙇

@FND
Copy link
Collaborator Author

FND commented Jan 17, 2025

To be honest, it seems perfectly fine for aiur to keep using metacolon 1.x for eternity. I just wasn't keen on worrying about soon-to-be-legacy runtimes in this particular rewrite.

If you do want to upgrade, I'd tried tracing the trailing \n to tree.js and page.js, but I feel like I no longer have a good grasp of how aiur works. metacolon 2.0 no longer trims whitespace though, so that's almost certainly the reason here.

@FND
Copy link
Collaborator Author

FND commented Jan 17, 2025

Never mind, I was being stupid: All fixed now.

EXCEPT: metacolon 2.0 currently assumes POSIX line endings (i.e. \n, no CRLF or any of that business). That might become an issue for users? (It's not an intentional limitation, just that I ran out of steam and didn't wanna deal with that particular hassle... )

@FND
Copy link
Collaborator Author

FND commented Jan 17, 2025

FWIW, your comment also made me realize that supporting Node v20 only takes trivial changes.

... except require($esm) doesn't work... 🤦 😩

note that this requires Node v22
@FND
Copy link
Collaborator Author

FND commented Jan 17, 2025

Turns out there are other issues here: I recommend not upgrading metacolon, probably ever. 😬

@FND FND closed this Jan 17, 2025
@FND FND mentioned this pull request Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants