Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Migrate Fat Free CRM to Rails 7 #1115

Closed
wants to merge 7 commits into from
Closed

WIP Migrate Fat Free CRM to Rails 7 #1115

wants to merge 7 commits into from

Conversation

johnbumgardner
Copy link
Member

@johnbumgardner johnbumgardner commented May 28, 2023

6.1->7.0

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubocop found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@johnbumgardner johnbumgardner changed the title upgrade to rails 7 Migrate Fat Free CRM to Rails 7 May 28, 2023
@johnbumgardner johnbumgardner changed the title Migrate Fat Free CRM to Rails 7 WIP Migrate Fat Free CRM to Rails 7 May 29, 2023
gem 'responds_to_parent', git: 'https://github.com/CloCkWeRX/responds_to_parent.git', branch: 'patch-2' # Temporarily pointed at git until https://github.com/zendesk/responds_to_parent/pull/7 is released
gem 'acts_as_commentable', git: 'https://github.com/fatfreecrm/acts_as_commentable.git', branch: 'rails-61' # Our fork
gem 'responds_to_parent'
gem 'acts_as_commentable'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be aware that the upstream maintainer of this gem went MIA.

jackdempsey/acts_as_commentable@master...fatfreecrm:acts_as_commentable:rails-61

I'd recommend forking from our version and making a rails-7 branch

@@ -86,8 +86,8 @@ group :heroku do
gem 'puma'
end

gem 'responds_to_parent', git: 'https://github.com/CloCkWeRX/responds_to_parent.git', branch: 'patch-2' # Temporarily pointed at git until https://github.com/zendesk/responds_to_parent/pull/7 is released
gem 'acts_as_commentable', git: 'https://github.com/fatfreecrm/acts_as_commentable.git', branch: 'rails-61' # Our fork
gem 'responds_to_parent'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto this one. Zendesk appear to be a bit useless at merging.

zendesk/responds_to_parent#7

@@ -49,6 +49,8 @@
# since changing the type of the database column would cause data to be lost.
#

require_relative 'field'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is something to do with the zeitgiest autoloader changes?

May be worth doing bundle exec zeitgiest:check and submitting all that as a standalone PR; then doing Rails 7 atop that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah im not sure why exactly. still working through this. ActiveRecord::Base.descendents end up having far less classes accounted for at any given instance

Copy link
Member

@CloCkWeRX CloCkWeRX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might need to be careful not to accidentally nuke the various copyright notices.

@hubyhuby
Copy link

Hope I am not disturbing here the google group is inactive for 1 year.
I am starting a green field project witgh fat free, I have started a onclick install for ruby on rails.
But digital Ocean now only offers rails 7.0. and fat free requires for now 6.1

I am wonderning if anyone has experience with Digital Ocean ?
Will it make any troubles running fat free on this instance ?
Thks for your help

https://www.digitalocean.com/community/tutorials/how-to-use-the-ruby-on-rails-1-click-install-on-digitalocean
image

Thks for this great CRM !

@ferrisoxide
Copy link
Contributor

@hubyhuby

I am wonderning if anyone has experience with Digital Ocean ?
Will it make any troubles running fat free on this instance ?
Thks for your help

I don't think it will work out of the box, simply because the default version of Ruby used by FatFreeCRM (Ruby 2.7.5) probably won't be supported on DO. I could be wrong - I haven't used the platform for a while - but as 2.7.5 has now reached EOL it's quite likely it won't be installable.

Having said that, the OneClick Install might bring up enough of the dependencies required for running FFCrm. You would have to muck around with the source (e.g. change .ruby-version to use 3.2.0) to get the code to run - but TBH I think our best bet is to bring the source up to spec with more recent versions of Ruby. I've created a PR to bring it up to 3.0.2 (see #1139) but it should be trivial to migrate to 3.2.0.

As an aside, you can install whatever you want on DO droplets - within reason. If you want an older Ruby you can install it by hand - assuming the distro you use still supports it - or by using a provisioning tool like Ansible, Chef, etc.

@CloCkWeRX
Copy link
Member

Probably broke things, but well, 3.1 is in so this is rebased to that.

@steveyken
Copy link
Member

Can this PR close now that FFCRM is Rails 7 or is there some outstanding code here to merge?

@CloCkWeRX CloCkWeRX closed this Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants