WIP Migrate Fat Free CRM to Rails 7 #1115
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Rubocop found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
johnbumgardner
changed the title
| gem 'responds_to_parent', git: 'https://github.com/CloCkWeRX/responds_to_parent.git', branch: 'patch-2' # Temporarily pointed at git until https://github.com/zendesk/responds_to_parent/pull/7 is released | ||
| gem 'acts_as_commentable', git: 'https://github.com/fatfreecrm/acts_as_commentable.git', branch: 'rails-61' # Our fork | ||
| gem 'responds_to_parent' | ||
| gem 'acts_as_commentable' |
There was a problem hiding this comment.
Be aware that the upstream maintainer of this gem went MIA.
jackdempsey/acts_as_commentable@master...fatfreecrm:acts_as_commentable:rails-61
I'd recommend forking from our version and making a rails-7 branch
| @@ -86,8 +86,8 @@ group :heroku do | |||
| gem 'puma' | |||
| end | |||
|
|
|||
| gem 'responds_to_parent', git: 'https://github.com/CloCkWeRX/responds_to_parent.git', branch: 'patch-2' # Temporarily pointed at git until https://github.com/zendesk/responds_to_parent/pull/7 is released | |||
| gem 'acts_as_commentable', git: 'https://github.com/fatfreecrm/acts_as_commentable.git', branch: 'rails-61' # Our fork | |||
| gem 'responds_to_parent' | |||
There was a problem hiding this comment.
Ditto this one. Zendesk appear to be a bit useless at merging.
| @@ -49,6 +49,8 @@ | |||
| # since changing the type of the database column would cause data to be lost. | |||
| # | |||
|
|
|||
| require_relative 'field' | |||
There was a problem hiding this comment.
I assume this is something to do with the zeitgiest autoloader changes?
May be worth doing bundle exec zeitgiest:check and submitting all that as a standalone PR; then doing Rails 7 atop that.
There was a problem hiding this comment.
yeah im not sure why exactly. still working through this. ActiveRecord::Base.descendents end up having far less classes accounted for at any given instance
|
Hope I am not disturbing here the google group is inactive for 1 year. I am wonderning if anyone has experience with Digital Ocean ? Thks for this great CRM ! |
I don't think it will work out of the box, simply because the default version of Ruby used by FatFreeCRM (Ruby 2.7.5) probably won't be supported on DO. I could be wrong - I haven't used the platform for a while - but as 2.7.5 has now reached EOL it's quite likely it won't be installable. Having said that, the OneClick Install might bring up enough of the dependencies required for running FFCrm. You would have to muck around with the source (e.g. change As an aside, you can install whatever you want on DO droplets - within reason. If you want an older Ruby you can install it by hand - assuming the distro you use still supports it - or by using a provisioning tool like Ansible, Chef, etc. |
|
Probably broke things, but well, 3.1 is in so this is rebased to that. |
|
Can this PR close now that FFCRM is Rails 7 or is there some outstanding code here to merge? |
6.1->7.0