-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve README and CONTRIBUTING guides #88
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a good improvement, thanks so much for this @stefannibrasil!
Just left a few comments
406b389
to
9671e23
Compare
hi @stefannibrasil! thanks for contributing! I can answer at least one of your questions -- relating to We use a format based on Keep A Changelog. The important things to note are:
As far as a good Skunk Score, I'm not really sure, but perhaps @etagwerker could help answer that one? |
Codecov Report
@@ Coverage Diff @@
## main #88 +/- ##
=======================================
Coverage 98.26% 98.26%
=======================================
Files 25 25
Lines 462 462
=======================================
Hits 454 454
Misses 8 8 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
@kindoflew @bronzdoc thank you for your review! I added more details about the Changelog. @etagwerker do you have any thoughts on adding a "healthy" SkunkScore to add as an example for people to compare their current score with? |
ping @etagwerker |
@kindoflew @stefannibrasil At this point I don't have an answer for that... I created an issue to improve this area of the gem: #95 I've been slowly uploading scores to http://skunk.fastruby.io to get a sense of "healthy" skunk scores in real projects. But I don't have any conclusive data yet... |
We really appreciate your contribution @stefannibrasil! I apologize for the delay, I think this is good to go and we can improve it later when we tackle #95 |
The README now contains steps to generating the code coverage report, how to use the SkunkScore as a refactoring guide, and a separate Contributing guide. I also cleaned up a bit the skunk report to help people focus on what matters. It's my first time opening a Pull Request here, curious to see your thoughts!
I have a couple of questions of things I'd like to add in the README:
Thanks!
I will abide by the code of conduct.