Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix forbidden KV key special characters to match documentation #1097

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

btsheehy
Copy link
Contributor

Related:
fastly/cli#1383
fastly/Viceroy#447

Currently the Compute Javascript SDK enforces an incorrect set of special characters that are forbidden in KV key names. The current behavior is forbidding [, ], *, ?, #, while the documentation lists ;, ^, |, #, and ?. Square brackets and asterisks are specifically called out as allowed characters.

I'm unfamiliar with this codebase, so it's entirely possible I've missed some files that need to be updated.

@guybedford
Copy link
Member

Thanks for posting. The other places we need to handle this are:

Let me know if you're able to update this PR to include those, or if I can assist further with this.

@btsheehy
Copy link
Contributor Author

Thanks for posting. The other places we need to handle this are:

Let me know if you're able to update this PR to include those, or if I can assist further with this.

I believe my original commit handled the first one, but I just committed a change to update the types files and any doc files I could find containing the error

@guybedford
Copy link
Member

Not sure why this isn't running CI correctly, but the PR looks good to me, will land and we can follow up if there are further issues.

@guybedford guybedford merged commit fefc024 into fastly:main Jan 29, 2025
17 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants