deps: update to latest WASI SDK 25

.github/workflows/main.yml

@@ -99,13 +99,13 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v3
-    - name: "Install wasi-sdk-20 (linux)"
+    - name: "Install wasi-sdk-25 (linux)"
       run: |
         set -x
-        curl -sS -L -O https://github.com/WebAssembly/wasi-sdk/releases/download/wasi-sdk-20/wasi-sdk-20.0-linux.tar.gz
-        tar xf wasi-sdk-20.0-linux.tar.gz
+        curl -sS -L -O https://github.com/WebAssembly/wasi-sdk/releases/download/wasi-sdk-25/wasi-sdk-25.0-x86_64-linux.tar.gz
+        tar xf wasi-sdk-25.0-x86_64-linux.tar.gz
         sudo mkdir -p /opt/wasi-sdk
-        sudo mv wasi-sdk-20.0/* /opt/wasi-sdk/
+        sudo mv wasi-sdk-25.0-x86_64-linux/* /opt/wasi-sdk/
         ls /opt/wasi-sdk/
     - run: |
         /opt/wasi-sdk/bin/clang-format --version

runtime/fastly/builtins/cache-core.cpp

@@ -74,7 +74,7 @@ JS::Result<host_api::CacheLookupOptions> parseLookupOptions(JSContext *cx,
       Headers::HeadersList *headers_list = Headers::get_list(cx, headers);
       MOZ_ASSERT(headers_list);
       auto res = host_api::write_headers(request_handle.headers_writable(), *headers_list);
-      if (auto *err = res.to_err()) {
+      if ([[maybe_unused]] auto *err = res.to_err()) {
         return JS::Result<host_api::CacheLookupOptions>(JS::Error());
       }
       options.request_headers = host_api::HttpReq(request_handle);
@@ -364,7 +364,7 @@ JS::Result<host_api::CacheWriteOptions> parseInsertOptions(JSContext *cx,
     Headers::HeadersList *headers_list = Headers::get_list(cx, headers);
     MOZ_ASSERT(headers_list);
     auto res = host_api::write_headers(request_handle.headers_writable(), *headers_list);
-    if (auto *err = res.to_err()) {
+    if ([[maybe_unused]] auto *err = res.to_err()) {
       return JS::Result<host_api::CacheWriteOptions>(JS::Error());
     }
     options.request_headers = host_api::HttpReq(request_handle);

runtime/fastly/builtins/cache-simple.cpp

@@ -329,7 +329,7 @@ bool get_or_set_then_handler(JSContext *cx, JS::HandleObject lookup_state, JS::H
   options.surrogate_keys = key_result.inspect();
 
   auto inserted_res = handle.transaction_insert_and_stream_back(options);
-  if (auto *err = inserted_res.to_err()) {
+  if ([[maybe_unused]] auto *err = inserted_res.to_err()) {
     return false;
   }
 
@@ -340,22 +340,22 @@ bool get_or_set_then_handler(JSContext *cx, JS::HandleObject lookup_state, JS::H
   // source_body will only be valid when the body is a Host-backed ReadableStream
   if (source_body.valid()) {
     auto res = body.append(source_body);
-    if (auto *error = res.to_err()) {
+    if ([[maybe_unused]] auto *error = res.to_err()) {
       return false;
     }
   } else {
     auto write_res = body.write_all_back(reinterpret_cast<uint8_t *>(buf.get()), options.length);
-    if (auto *error = write_res.to_err()) {
+    if ([[maybe_unused]] auto *error = write_res.to_err()) {
       return false;
     }
     auto close_res = body.close();
-    if (auto *error = close_res.to_err()) {
+    if ([[maybe_unused]] auto *error = close_res.to_err()) {
       return false;
     }
   }
 
   auto res = inserted_handle.get_body(host_api::CacheGetBodyOptions{});
-  if (auto *err = res.to_err()) {
+  if ([[maybe_unused]] auto *err = res.to_err()) {
     return false;
   }
 
@@ -442,15 +442,15 @@ bool SimpleCache::getOrSet(JSContext *cx, unsigned argc, JS::Value *vp) {
   // cache under the provided `key`, and then we will resolve with a SimpleCacheEntry
   // containing the value.
   auto state_res = handle.get_state();
-  if (auto *err = state_res.to_err()) {
+  if ([[maybe_unused]] auto *err = state_res.to_err()) {
     return false;
   }
 
   auto state = state_res.unwrap();
   args.rval().setObject(*promise);
   if (state.is_usable()) {
     auto body_res = handle.get_body(host_api::CacheGetBodyOptions{});
-    if (auto *err = body_res.to_err()) {
+    if ([[maybe_unused]] auto *err = body_res.to_err()) {
       return false;
     }
 

runtime/fastly/host-api/host_api_fastly.h

@@ -355,7 +355,7 @@ struct TlsVersion {
   uint8_t value = 0;
 
   explicit TlsVersion(uint8_t raw);
-  explicit TlsVersion(){};
+  explicit TlsVersion() {};
 
   uint8_t get_version() const;
   double get_version_number() const;