Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: StarlingMonkey update #1067

Merged
merged 18 commits into from
Dec 9, 2024
Merged

feat: StarlingMonkey update #1067

merged 18 commits into from
Dec 9, 2024

Conversation

guybedford
Copy link
Member

@guybedford guybedford commented Dec 6, 2024

This updates to the latest StarlingMonkey, featuring the new Blob support.

This StarlingMonkey upgrade was a bit more involved

  • Updated the base-level task system to support the new "immediate" task type, and also added a new phase where async_is_ready is used instead of async_select when immediates are in play to avoid large timeouts of 1ms.
  • Updated to the new cmake structure allowing us to remove the unused WASI bindings files
  • Updated the fetch API integration on the Fastly side to match some refactorings made to native streams by the blob work
  • Updated our own web platform tests based on the above.

This initially also included a port of the new Response(blob) and Response.blob support, but these were removed due to a bug appearing only in release builds and only for the test /override-content-length/request/init/object-literal/true which should not strictly speaking be related to
In addition, manual implementation is also included to support new Response(blob) per the spec, and added an integration test to demonstrate full end to end blob usage.

@guybedford guybedford changed the title feat: StarlingMonkey update & Blob support feat: StarlingMonkey update Dec 9, 2024
@guybedford guybedford merged commit 857f6fa into main Dec 9, 2024
25 checks passed
@guybedford guybedford deleted the starlingmonkey-update branch December 9, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant