Migration to node test runner #495
Open
+2,082
−2,829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dancastillo
reviewed
Jan 4, 2025
dancastillo
reviewed
Jan 4, 2025
dancastillo
reviewed
Jan 5, 2025
package.json
Outdated
| "lint": "eslint", | ||
| "lint:fix": "eslint --fix", | ||
| "test": "npm run test:unit && npm run test:typescript", | ||
| "test:typescript": "tsd", | ||
| "test:unit": "tap", | ||
| "test:unit": "c8 --100 node --test **/*.test.js", |
There was a problem hiding this comment.
this should be the equivalent
Suggested change
| "test:unit": "c8 --100 node --test **/*.test.js", | |
| "test:unit": "c8 --100 node --test", |
There was a problem hiding this comment.
Not on node 20. Without pattern it tries to read the no-link file and fails to run the tests as It points to something that doesn't exists
Co-authored-by: Dan Castillo <[email protected]> Signed-off-by: Matteo Pietro Dazzi <[email protected]>
This was referenced Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
run
npm run testandnpm run benchmarktests and/or benchmarks are included
documentation is changed or added
commit message and code follows the Developer's Certification of Origin
and the Code of conduct
Migrated to node test runner
Removed simple-get in favour of fetch