🐛 Fix loginAccessToken Prop in useAuth.ts to Resolve 400 Error on dashboard login #1688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejsdev
changed the title
YuriiMotov
reviewed
Sep 3, 2025
There was a problem hiding this comment.
It seems that there is no type mismatch here.
dataparameter has typeBody_login_login_access_token(see import:type Body_login_login_access_token as AccessToken)loginAccessTokenaccepts parameter of typeLoginLoginAccessTokenData(see implementation)LoginLoginAccessTokenDatais defined as{formData: Body_login_login_access_token}(see declaration)
And, application/x-www-form-urlencoded is hardcoded here. So, it shouldn't depend on data passed to this function.
So, everything seems to be correct in current implementation and no changes needed.
@gregorvolkmann, could you please double-check?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an HTTP 400 error in production by updating the login function in frontend/src/hooks/useAuth.ts. The LoginService.loginAccessToken call was incorrectly passing { formData: data } instead of { formData: { data.username, data.password } }, causing a type mismatch and sending multipart/form-data instead of application/x-www-form-urlencoded. The change ensures compliance with the LoginLoginAccessTokenData type and corrects the login request format.