Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Simplify reset password logic by removing duplicate code #1440

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

youneshenniwrites
Copy link

@youneshenniwrites youneshenniwrites commented Dec 3, 2024

Description

This pull request refactors the reset_password API endpoint to delegate password hashing and database update logic to the existing crud.update_user method.

The original implementation in reset_password contained redundant code that is already handled in crud.py, resulting in unnecessary duplication.

This refactor aims to keep the password update process and database queries in one place (crud.py), making it easier to manage and update if needed.

@youneshenniwrites youneshenniwrites changed the title chore: refactor reset password to avoid duplicate code Chore: refactor reset password to avoid duplicate code Dec 3, 2024
@youneshenniwrites youneshenniwrites changed the title Chore: refactor reset password to avoid duplicate code Refactor: Simplify Reset Password Logic by Removing Duplicate Code Dec 3, 2024
@alejsdev alejsdev changed the title Refactor: Simplify Reset Password Logic by Removing Duplicate Code ♻️ Simplify reset password logic by removing duplicate code Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants