add create_resources and rename environment parameter #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e create_resource to instanciate some certonly ressource
…e create_resource to instanciate some certonly ressource
This is a fix for voxpupuli#63. We rename the `environment` to `venv_vars` in order to ensure that hiera calls do *not* break, as soon as a puppet execution flow enters our module. For consistency's sake, we change `environment` not only in the main class (where it's definitely needed: rodjek/puppet-lint#574), but also in the `certonly` define.
…urces Conflicts: manifests/certonly.pp spec/classes/letsencrypt_spec.rb spec/defines/letsencrypt_certonly_spec.rb
Conflicts: manifests/init.pp
This changes the name to avoid potential confusion with the letsencrypt::certonly defined type; now the certs to be created via this create_resources are specified via the hiera or class param letsencrypt::certs.
This updates what the certonly type requires - to be used via the create_resources in init, can't depend on the whole class. For now just depend on the exec.
|
Closing this, going to keep our master branch tracking upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls in upstream PR voxpupuli#64 and voxpupuli#77 (with minor modifications after pulling in voxpupuli#77)