Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added type hints and pytest tests #374

Merged
merged 3 commits into from
May 31, 2021

Conversation

TolstochenkoDaniil
Copy link
Contributor

patterns/behavioral/strategy.py Outdated Show resolved Hide resolved
patterns/behavioral/strategy.py Outdated Show resolved Hide resolved
patterns/behavioral/strategy.py Show resolved Hide resolved
@TolstochenkoDaniil TolstochenkoDaniil marked this pull request as draft May 28, 2021 05:43
@TolstochenkoDaniil TolstochenkoDaniil marked this pull request as ready for review May 28, 2021 06:12
@faif
Copy link
Owner

faif commented May 29, 2021

@TolstochenkoDaniil Can you please fix the linter errors? If it's too much work for all, at least only for the files that you modified.

@TolstochenkoDaniil
Copy link
Contributor Author

for

@TolstochenkoDaniil Can you please fix the linter errors? If it's too much work for all, at least only for the files that you modified.

I'll check the errors, but tox completed ok before commit
Will do my best

@codecov-commenter
Copy link

codecov-commenter commented May 31, 2021

Codecov Report

Merging #374 (c0677d7) into master (4fcbf1b) will increase coverage by 2.28%.
The diff coverage is 96.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #374      +/-   ##
==========================================
+ Coverage   30.87%   33.15%   +2.28%     
==========================================
  Files          39       39              
  Lines        1286     1306      +20     
==========================================
+ Hits          397      433      +36     
+ Misses        889      873      -16     
Impacted Files Coverage Δ
patterns/structural/3-tier.py 0.00% <ø> (ø)
patterns/structural/front_controller.py 0.00% <ø> (ø)
patterns/behavioral/strategy.py 90.00% <96.42%> (+90.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fcbf1b...c0677d7. Read the comment docs.

@faif faif merged commit 5f47b07 into faif:master May 31, 2021
@faif
Copy link
Owner

faif commented May 31, 2021

Let's create a new issue for the remaining linter errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants