Add support for Alt-Left/Right and Alt-Backspace editing #9
Conversation
src/prompt/cursor.rs
Outdated
| let ix = jumps | ||
| .binary_search(&self.cursor) | ||
| .map_or_else(|i| i, |i| i + 1); | ||
| self.cursor = jumps[std::cmp::min(ix, jumps.len() - 1)]; |
There was a problem hiding this comment.
Well, jump.len() will never be zero inside of this if condition, however, saturating_sub is just safer.
| self.cursor = jumps[std::cmp::min(ix, jumps.len() - 1)]; | |
| self.cursor = jumps[std::cmp::min(ix, jumps.len().saturating_sub(1))]; |
| // Alt-Backspace | ||
| Key::Char('\u{17}') if word_editing => cursor.delete_word_left(), | ||
|
|
||
| // Alt-ArrowLeft |
There was a problem hiding this comment.
Basically, Ctrl-Left/Ctrl-Right behave similarly in Bash, could Ctrl be enabled as well? Thanks!
There was a problem hiding this comment.
yes... but i propose doing so in a separate PR :)
|
Thanks for the review @fadeevab -- taking a look now! I also noticed that while alt+{left, right, backspace} work locally, they don't seem to work over SSH. I'll debug... |
|
@samuela what are you going to do with this? Does it work as expected? Need to rebase it also. |
Care has been taken to disable these features for `Password` interactions via the introduced `allow_word_editing(&self) -> bool` function on `PromptInteraction`. A default `true` implementation has been provided.
samuela
force-pushed
the
samuela/word-editing
branch
from
7e9b848 to
6ba53f3
Compare
Yup, rebase done and comments addressed. I just spent a few hours tracking down the SSH issues. Turns out that it's not really an SSH issue, it's an iTerm configuration issue. So I think this should be ready for merging now. |
Fix #5.
This PR is built off of #8, so it would be easiest to merge that one first. To review this diff, it may be easiest to look at the changes from 7e9b848 only.