This repository has been archived by the owner on Feb 22, 2024. It is now read-only.
Fix ROSMessage::updateMissingPkgNames() for ambiguous message names #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
ROSMessage::updateMissingPkgNames()
for the case that types with the same message name but different package names are registered.We used
ros_msg_parser
in a case where a message was using two different definitions ofHeader
, a custom one with additional fields, but alsostd_msgs/Header
indirectly via a nestedgeometry_msgs/Vector3Stamped
defined asso without an explicit package name for
Header
andVector3
. The previous implementation ofROSMessage::updateMissingPkgNames()
then completed this type with the name of the custom package, whoseHeader
message was registered first, and hence parsing failed.According to the rules defined in http://wiki.ros.org/msg#Fields unqualified types must be resolved in the local package only, with
Header
as the only exception. I assume thatHeader
is only resolved tostd_msgs/Header
if no message namedHeader
is defined in the same package.