Prompt user when one or more topics in the rosbag cannot be loaded #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* previous behaviour: the bag load was aborted * with this patch: prompt user whether or not to * skip this problematic topic and continue loading * skip this and other problematic topics that may arise when loading * abort the load The patch addresses a real life example when some of the ros messages are created from ROS-matlab, and therefore suffers from a bug related to a bad message description E.g. see rosjava/rosjava_bootstrap#16
|
the issue with rosjava explains a few weird things that happened to people I know in the past... Thanks for the addition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch addresses a real life example when some of the ros messages are created
from ROS-matlab, and therefore suffers from a bug related to a bad message description
E.g. see rosjava/rosjava_bootstrap#16