Fix/add missing notebook dependencies #274
Open
+15
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the issue where importing sam3 causes cv2.imshow() to segfault
due to decord being imported at module level, which conflicts with OpenCV.
Changes:
- Removed module-level import of decord from sam3_image_dataset.py
- Added lazy import inside _load_images() method when processing .mp4 files
- Decord now only loads when actually needed, preventing the conflict
Fixes the issue reported where:
import cv2
from sam3.model_builder import build_sam3_image_model
cv2.imshow('test', frame) # Would segfault before this fix
- Add triton with platform-specific handling (triton-windows for Windows, triton for Linux/Mac) - Fixes issue where einops, decord, pycocotools, and triton were missing when running Jupyter notebooks - Addresses feedback from Windows users who had to manually install these packages
meta-cla
bot
added
the
CLA Signed
drduhe
approved these changes
Dec 11, 2025
drduhe
left a comment
drduhe
left a comment
There was a problem hiding this comment.
Looks good to me and same thing as my comment in the other PR about potential README updates to let users know about the video support.
|
Great! Looking forward to this change so that I can run my notebook. Thanks @mattiagaggi and @drduhe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #252
Summary
Fixes issue where several required packages were missing when running Jupyter notebooks after installing with
pip install -e ".[notebooks]".Changes
tritonwith platform-specific handling tonotebooksoptional dependenciestriton-windows; sys_platform == 'win32'triton; sys_platform != 'win32'Problem
Users reported missing modules when running notebooks:
einops(already present)decord(already present)pycocotools(already present)triton/triton-windows(was missing)Solution
The
tritonpackage is required for core model functionality (used insam3/model/edt.pyandsam3/model/sam3_tracker_utils.py). Adding it to the notebooks dependencies ensures it's automatically installed when users runpip install -e ".[notebooks]".Testing