-
Notifications
You must be signed in to change notification settings - Fork 428
Add demo for accurate pointmap-based 3D reconstruction #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi @codepk37! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
hi @codepk37 FYI, i was using realsense d435 |
|
Hi @trungpham2606, thanks for checking out notebook It would make easier to reproduce issue and debug |
|
hi @codepk37 |
|
I checked the reconstruction on my side and the size looks right (for example, the scissor length matches). |
|
hi @codepk37 |
|
Hi @gleize can you confirm about my concern ? Tks |
|
hi @codepk37 can you test with this data as well |
Hi @trungpham2606, this PR provides a reconstruction demo using pointmaps. The code has been verified on multiple datasets, including your first sample. Differences in scale, pose, or shape in new examples likely come from the model itself, which can have limitations, rather than the demo code. |
I think so @codepk37 tks for your code. |
|
Hi @codepk37, I was reading through the function transform_mesh_vertices in the demo notebook, and I think I may have found a potential inconsistency related to the coordinate-frame conversion. In the code:
Because of that, the returned value is still in Z-up coordinates (i.e., PyTorch3D / pointmap convention), not Y-up. The comment suggests the return should be Y-up, but based on the current code flow, the returned vertices never go through R_zup_to_yup. So I want to confirm my understanding: |
|
Hi @Cooper-903 |


This PR adds a new notebook demonstrating 3D reconstruction using depth + camera intrinsics to generate a pointmap, followed by mesh alignment.
Key points
Usage / Validation:
Visualized scene
Exported mesh preserving relative pose
Objects scale and position consistent with pointcloud