Fix documentation typos and syntax errors in README.md #120
+279
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix typo: maintstream -> mainstream - Fix typo: Shudown -> Shutdown - Fix typo: min_replia -> min_replica - Fix quote inconsistency in Gemini example (name field) - Add missing quotes for sglang_llm app_type - Fix typos: botttleneck -> bottleneck, generaion -> generation Per CONTRIBUTING.md (3-13): Updated documentation to ensure clarity and correctness.
devopsdymyr
requested review from
dongwang218,
swdanielli and
yangli5t
as code owners
meta-cla
bot
added
the
CLA Signed
…acebookresearch#111) - Add get_gpu_requirements_per_replica() to calculate GPU needs per app - Add sort_apps_by_gpu_requirements() to sort apps by GPU requirements (largest first) - Integrate sorting into deploy() method when deploying multiple apps - Add comprehensive unit tests for fragmentation fix This prevents resource fragmentation by deploying models requiring more GPUs first, leaving smaller contiguous blocks for models requiring fewer GPUs. Fixes facebookresearch#111
dongwang218
reviewed
Dec 10, 2025
| logger.info( | ||
| "Sorting applications by GPU requirements (largest first) to minimize fragmentation" | ||
| ) | ||
| applications = sort_apps_by_gpu_requirements(applications) |
Contributor
There was a problem hiding this comment.
not sure if sorting makes a difference?
Existing deployment could partially occupy a node, which prevent later deployment to get resources without removing old one. Not sure if Ray also does a poor job of compaction for multiple models in the same deployment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix documentation typos and syntax errors in README.md
Summary
This PR fixes several typos and syntax errors found in the README.md documentation to improve clarity and correctness.
Changes Made
maintstream→mainstream(line 32)Shudown→Shutdown(line 100)min_replia→min_replica(line 141)'name': "gemini"→'name': 'gemini'(line 155)sglang_llmapp_type:app_type:sglang_llm→'sglang_llm'(line 164)botttleneck→bottleneckandgeneraion→generation(line 329)Why?
These documentation errors can cause confusion for users following the README examples and reduce the professional quality of the documentation. Fixing these typos and syntax errors ensures:
How?
All changes are straightforward typo corrections and syntax fixes:
Per CONTRIBUTING.md guidelines (lines 3-13): Updated documentation to ensure clarity and correctness.
Test Plan
git diffto ensure accuracyType of Change
Checklist
mainContributor License Agreement
I understand that a CLA may be required for this contribution. I will complete it if requested by the maintainers.