Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control humanoid velocity from config. #2060

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

0mdc
Copy link
Contributor

@0mdc 0mdc commented Aug 31, 2024

Motivation and Context

WIP - Open for discussion.

In the current state of the code, the humanoid speed is capped by the estimated speed of the animation.
This is cosmetic - it prevents the walking animation to have a gliding appearance. I believe that this comes from early VR integrations.

In practice, this means that the lin_speed config field has no effect past a certain value.

This brings the following issues:

  • The humanoid speed is not driven by config.
  • Many experiments must cherry-pick this hack to work as intended.
  • In HITL, the humanoid is too slow, which greatly increases episode completion speed.

Proposed change:

  • By default, the humanoid should follow lin_speed perfectly, like the other agent types.
    • This may impact training.

Proposed BE Improvements:

  • To keep the animation in-sync with the humanoid velocity, the animation framerate should change.
  • Refactors:
    • This class should get its configuration from a single source of truth.
    • Calculations should be simplified.

How Has This Been Tested

Tested on HITL application.

Types of changes

  • [Development]

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 31, 2024
@0mdc 0mdc changed the title Add switch for allowing to control humanoid velocity from config. Control humanoid velocity from config. Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants