Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync device in shift_kjt_by_one #679

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

clairecyq
Copy link

Summary: Use the same device for constant tensor as input tensor to avoid concatenating tensors on separate devices

Reviewed By: czxttkl

Differential Revision: D39020305

Summary: Use the same device for constant tensor as input tensor to avoid concatenating tensors on separate devices

Reviewed By: czxttkl

Differential Revision: D39020305

fbshipit-source-id: 35ad9d41521b92914717c28f6c0eebc106a09abc
@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D39020305

@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2022

Codecov Report

Merging #679 (c7f673d) into main (e8fe386) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #679   +/-   ##
=======================================
  Coverage   87.48%   87.48%           
=======================================
  Files         366      366           
  Lines       23398    23398           
  Branches       44       44           
=======================================
  Hits        20470    20470           
  Misses       2902     2902           
  Partials       26       26           
Impacted Files Coverage Δ
reagent/core/torch_utils.py 92.39% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@facebook-github-bot
Copy link

Hi @clairecyq!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants