Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable sample weight in ReinforceTrainer #631

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gji1
Copy link
Contributor

@gji1 gji1 commented Apr 19, 2022

Summary: To cater for the negative subsampling scheme of the creative ranking project.

Differential Revision: D35664393

Summary: To cater for the negative subsampling scheme of the creative ranking project.

Differential Revision: D35664393

fbshipit-source-id: a0e2752a07024b6650cf17adfba3ae00052233ec
@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D35664393

@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2022

Codecov Report

Merging #631 (4b3fda5) into main (6b8cfb9) will decrease coverage by 0.03%.
The diff coverage is 56.66%.

@@            Coverage Diff             @@
##             main     #631      +/-   ##
==========================================
- Coverage   86.84%   86.80%   -0.04%     
==========================================
  Files         350      350              
  Lines       22205    22226      +21     
  Branches       44       44              
==========================================
+ Hits        19283    19294      +11     
- Misses       2896     2906      +10     
  Partials       26       26              
Impacted Files Coverage Δ
reagent/training/reinforce_trainer.py 67.34% <40.00%> (-3.44%) ⬇️
reagent/training/utils.py 87.80% <71.42%> (-8.87%) ⬇️
reagent/core/types.py 86.70% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b8cfb9...4b3fda5. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants