Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Register Spark array_join function #11948

Closed
wants to merge 5 commits into from
Closed

feat: Register Spark array_join function #11948

wants to merge 5 commits into from
+25 −0

Conversation

zhli1142015
Copy link
Contributor

@zhli1142015 zhli1142015 commented Dec 24, 2024 •
edited by rui-mo
Loading

Gluten removed the registration of Presto sql functions. This PR registers
Presto array_join function in Spark for reuse.

apache/incubator-gluten#2705

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 24, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 24, 2024 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 9c7282d
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/67775033167d210008e30afa

@zhli1142015
Copy link
Contributor Author

cc @rui-mo and @PHILO-HE , thanks.

PHILO-HE
PHILO-HE approved these changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@PHILO-HE PHILO-HE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@zhli1142015 zhli1142015 mentioned this pull request Dec 24, 2024
Closed
rui-mo
rui-mo reviewed Dec 24, 2024
View reviewed changes
Copy link
Collaborator

@rui-mo rui-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks this is missed in refactor

Just wondering which refactor it refers to, as we might also need to confirm the other missing cases if so.

velox/docs/functions/spark/array.rst Outdated Show resolved Hide resolved
velox/docs/functions/spark/array.rst Outdated Show resolved Hide resolved
@zhli1142015
Copy link
Contributor Author

Looks this is missed in refactor

Just wondering which refactor it refers to, as we might also need to confirm the other missing cases if so.

apache/incubator-gluten#8319 (comment)

@zhli1142015 zhli1142015 requested a review from rui-mo December 24, 2024 11:20
rui-mo
rui-mo reviewed Dec 27, 2024
View reviewed changes
Copy link
Collaborator

@rui-mo rui-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

velox/docs/functions/spark/array.rst Outdated Show resolved Hide resolved
velox/docs/functions/spark/array.rst Outdated Show resolved Hide resolved
velox/docs/functions/spark/array.rst Outdated Show resolved Hide resolved
@zhli1142015 zhli1142015 requested a review from rui-mo December 27, 2024 02:35
@zhli1142015 zhli1142015 requested a review from rui-mo December 31, 2024 03:54
@rui-mo rui-mo added the ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall label Jan 6, 2025
@facebook-github-bot
Copy link
Contributor

@kevinwilfong has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kevinwilfong merged this pull request in d5e330b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkhaliqi jkhaliqi jkhaliqi approved these changes

@rui-mo rui-mo rui-mo approved these changes

@PHILO-HE PHILO-HE PHILO-HE approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zhli1142015 @facebook-github-bot @PHILO-HE @rui-mo @jkhaliqi