feat: Support to disable dynamic filter reordering #11943
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D67542368 |
Yuhta
approved these changes
Dec 23, 2024
xiaoxmeng
added a commit
to xiaoxmeng/velox
that referenced
this pull request
Dec 24, 2024
…#11943) Summary: Pull Request resolved: facebookincubator#11943 Add config to disable dynamic filter reordering to see if it can help reduce io in favor of small query execution if io wait could take significant amount when having local ssd. The static reordering solely based on the filter kind. This should only be used in specific case as dynamic filter reordering is an important scan optimization. Reviewed By: Yuhta, oerling Differential Revision: D67542368
xiaoxmeng
force-pushed
the
export-D67542368
branch
from
c4326ec to
9c18804
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67542368 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D67542368 |
xiaoxmeng
added a commit
to xiaoxmeng/velox
that referenced
this pull request
Dec 24, 2024
…#11943) Summary: Pull Request resolved: facebookincubator#11943 Add config to disable dynamic filter reordering to see if it can help reduce io in favor of small query execution if io wait could take significant amount when having local ssd. The static reordering solely based on the filter kind. This should only be used in specific case as dynamic filter reordering is an important scan optimization. Reviewed By: Yuhta, oerling Differential Revision: D67542368
xiaoxmeng
force-pushed
the
export-D67542368
branch
from
9c18804 to
bccece1
Compare
xiaoxmeng
added a commit
to xiaoxmeng/velox
that referenced
this pull request
Dec 24, 2024
…#11943) Summary: Pull Request resolved: facebookincubator#11943 Add config to disable dynamic filter reordering to see if it can help reduce io in favor of small query execution if io wait could take significant amount when having local ssd. The static reordering solely based on the filter kind. This should only be used in specific case as dynamic filter reordering is an important scan optimization. Reviewed By: Yuhta, oerling Differential Revision: D67542368
xiaoxmeng
force-pushed
the
export-D67542368
branch
from
bccece1 to
97249d1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67542368 |
xiaoxmeng
added a commit
to xiaoxmeng/velox
that referenced
this pull request
Dec 24, 2024
…#11943) Summary: Pull Request resolved: facebookincubator#11943 Add config to disable dynamic filter reordering to see if it can help reduce io in favor of small query execution if io wait could take significant amount when having local ssd. The static reordering solely based on the filter kind. This should only be used in specific case as dynamic filter reordering is an important scan optimization. Reviewed By: Yuhta, oerling Differential Revision: D67542368
xiaoxmeng
force-pushed
the
export-D67542368
branch
from
97249d1 to
34b6212
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67542368 |
xiaoxmeng
added a commit
to xiaoxmeng/velox
that referenced
this pull request
Dec 24, 2024
…#11943) Summary: Pull Request resolved: facebookincubator#11943 Add config to disable dynamic filter reordering to see if it can help reduce io in favor of small query execution if io wait could take significant amount when having local ssd. The static reordering solely based on the filter kind. This should only be used in specific case as dynamic filter reordering is an important scan optimization. Reviewed By: Yuhta, oerling Differential Revision: D67542368
xiaoxmeng
force-pushed
the
export-D67542368
branch
from
34b6212 to
10a8635
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67542368 |
xiaoxmeng
added a commit
to xiaoxmeng/velox
that referenced
this pull request
Dec 25, 2024
…#11943) Summary: Pull Request resolved: facebookincubator#11943 Add config to disable dynamic filter reordering to see if it can help reduce io in favor of small query execution if io wait could take significant amount when having local ssd. The static reordering solely based on the filter kind. This should only be used in specific case as dynamic filter reordering is an important scan optimization. Reviewed By: Yuhta, oerling Differential Revision: D67542368
xiaoxmeng
force-pushed
the
export-D67542368
branch
from
10a8635 to
b9c9ea9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67542368 |
xiaoxmeng
added a commit
to xiaoxmeng/velox
that referenced
this pull request
Dec 25, 2024
…cebookincubator#11943) Summary: Pull Request resolved: facebookincubator#11943 Add config to disable dynamic filter reordering to see if it can help reduce io in favor of small query execution if io wait could take significant amount when having local ssd. The static reordering solely based on the filter kind. This should only be used in specific case as dynamic filter reordering is an important scan optimization. This PR also improve non-stats based filter ordering by comparing the field name if filter kind ties. This might save some IOs with cache with more consistent filter ordering. Reviewed By: Yuhta, oerling Differential Revision: D67542368
xiaoxmeng
force-pushed
the
export-D67542368
branch
from
b9c9ea9 to
f8488c2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67542368 |
…cebookincubator#11943) Summary: Pull Request resolved: facebookincubator#11943 Add config to disable dynamic filter reordering to see if it can help reduce io in favor of small query execution if io wait could take significant amount when having local ssd. The static reordering solely based on the filter kind. This should only be used in specific case as dynamic filter reordering is an important scan optimization. This PR also improve non-stats based filter ordering by comparing the field name if filter kind ties. This might save some IOs with cache with more consistent filter ordering. Reviewed By: Yuhta, oerling Differential Revision: D67542368
|
This pull request was exported from Phabricator. Differential Revision: D67542368 |
xiaoxmeng
force-pushed
the
export-D67542368
branch
from
f8488c2 to
5a4d790
Compare
|
This pull request has been merged in 48e3a4d. |
athmaja-n
pushed a commit
to athmaja-n/velox
that referenced
this pull request
Jan 10, 2025
…cebookincubator#11943) Summary: Pull Request resolved: facebookincubator#11943 Add config to disable dynamic filter reordering to see if it can help reduce io in favor of small query execution if io wait could take significant amount when having local ssd. The static reordering solely based on the filter kind. This should only be used in specific case as dynamic filter reordering is an important scan optimization. This PR also improve non-stats based filter ordering by comparing the field name if filter kind ties. This might save some IOs with cache with more consistent filter ordering. Reviewed By: Yuhta, oerling Differential Revision: D67542368 fbshipit-source-id: d1138c916fd77c975577e4a1e7f804dc3dbdf270
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add config to disable dynamic filter reordering to see if it can help reduce io in favor of small query execution
if io wait could take significant amount when having local ssd. The static reordering solely based on the filter kind.
This should only be used in specific case as dynamic filter reordering is an important scan optimization.
Differential Revision: D67542368