Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ip_subnet_max/min [5/n] #11515

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yuandagits
Copy link
Contributor

Summary:
Add ip_subnet and ip_subnetmax.

Split from #11407

Differential Revision: D65833249

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 12, 2024
Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit a1284e9
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/677c7505975f6e0008d1853e

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65833249

yuandagits added a commit to yuandagits/velox that referenced this pull request Nov 12, 2024
Summary:

Add ip_subnet and ip_subnetmax.

Split from facebookincubator#11407

Differential Revision: D65833249
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65833249

yuandagits added a commit to yuandagits/velox that referenced this pull request Nov 12, 2024
Summary:

Add ip_subnet and ip_subnetmax.

Split from facebookincubator#11407

Differential Revision: D65833249
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65833249

yuandagits added a commit to yuandagits/velox that referenced this pull request Nov 12, 2024
Summary:

Add ip_subnet and ip_subnetmax.

Split from facebookincubator#11407

Differential Revision: D65833249
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65833249

yuandagits added a commit to yuandagits/velox that referenced this pull request Nov 12, 2024
Summary:

Add ip_subnet and ip_subnetmax.

Split from facebookincubator#11407

Differential Revision: D65833249
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65833249

yuandagits added a commit to yuandagits/velox that referenced this pull request Nov 15, 2024
Summary:

Add ip_subnet and ip_subnetmax.

Split from facebookincubator#11407

Differential Revision: D65833249
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65833249

@yuandagits yuandagits changed the title Add ip_subnet_max/min [4/n] feat: Add ip_subnet_max/min [4/n] Nov 20, 2024
yuandagits added a commit to yuandagits/velox that referenced this pull request Dec 6, 2024
Summary:

Add ip_subnet and ip_subnetmax.

Split from facebookincubator#11407

Differential Revision: D65833249
yuandagits added a commit to yuandagits/velox that referenced this pull request Dec 6, 2024
Summary:

Add ip_subnet and ip_subnetmax.

Split from facebookincubator#11407

Differential Revision: D65833249
@yuandagits yuandagits changed the title feat: Add ip_subnet_max/min [4/n] feat: Add ip_subnet_max/min [5/n] Dec 12, 2024
yuandagits added a commit to yuandagits/velox that referenced this pull request Dec 18, 2024
Summary:

Add ip_subnet and ip_subnetmax.

Split from facebookincubator#11407

Differential Revision: D65833249
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65833249

yuandagits added a commit to yuandagits/velox that referenced this pull request Dec 22, 2024
Summary:

Add ip_subnet and ip_subnetmax.

Split from facebookincubator#11407

Differential Revision: D65833249
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65833249

yuandagits added a commit to yuandagits/velox that referenced this pull request Dec 22, 2024
Summary:

Add ip_subnet and ip_subnetmax.

Split from facebookincubator#11407

Differential Revision: D65833249
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65833249

yuandagits added a commit to yuandagits/velox that referenced this pull request Dec 22, 2024
Summary:

Add ip_subnet and ip_subnetmax.

Split from facebookincubator#11407

Differential Revision: D65833249
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65833249

yuandagits added a commit to yuandagits/velox that referenced this pull request Dec 22, 2024
Summary:

Add ip_subnet and ip_subnetmax.

Split from facebookincubator#11407

Differential Revision: D65833249
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65833249

Summary:

Add ip_subnet and ip_subnetmax.

Split from facebookincubator#11407

Differential Revision: D65833249
@yuandagits
Copy link
Contributor Author

cc @mohsaka

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65833249

@yuandagits yuandagits requested a review from xiaoxmeng January 7, 2025 00:28
Copy link
Contributor

@mohsaka mohsaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants