feat: Add ip_prefix function [4/n] #11514
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D65802211 |
yuandagits
force-pushed
the
export-D65802211
branch
from
1521c1c to
29dfe37
Compare
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 12, 2024
Summary: Add ip_prefix function which takes in varchar or ipaddress along with a prefixBits. Use folly lib to convert the varchar or ipaddress type to folly::IPAddressV6, and then apply the mask. We return a tuple<int128_t, int8_t> which corresponds to the ipaddress and prefix for IPAddressPrefix type. Differential Revision: D65802211
|
This pull request was exported from Phabricator. Differential Revision: D65802211 |
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 12, 2024
Summary: Add ip_prefix function which takes in varchar or ipaddress along with a prefixBits. Use folly lib to convert the varchar or ipaddress type to folly::IPAddressV6, and then apply the mask. We return a tuple<int128_t, int8_t> which corresponds to the ipaddress and prefix for IPAddressPrefix type. Split from facebookincubator#11407 Differential Revision: D65802211
yuandagits
force-pushed
the
export-D65802211
branch
from
29dfe37 to
da9fde7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65802211 |
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 12, 2024
Summary: Add ip_prefix function which takes in varchar or ipaddress along with a prefixBits. Use folly lib to convert the varchar or ipaddress type to folly::IPAddressV6, and then apply the mask. We return a tuple<int128_t, int8_t> which corresponds to the ipaddress and prefix for IPAddressPrefix type. Split from facebookincubator#11407 Differential Revision: D65802211
yuandagits
force-pushed
the
export-D65802211
branch
from
da9fde7 to
f6f6f32
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65802211 |
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 12, 2024
Summary: Add ip_prefix function which takes in varchar or ipaddress along with a prefixBits. Use folly lib to convert the varchar or ipaddress type to folly::IPAddressV6, and then apply the mask. We return a tuple<int128_t, int8_t> which corresponds to the ipaddress and prefix for IPAddressPrefix type. Split from facebookincubator#11407 Differential Revision: D65802211
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 12, 2024
Summary: Add ip_prefix function which takes in varchar or ipaddress along with a prefixBits. Use folly lib to convert the varchar or ipaddress type to folly::IPAddressV6, and then apply the mask. We return a tuple<int128_t, int8_t> which corresponds to the ipaddress and prefix for IPAddressPrefix type. Split from facebookincubator#11407 Differential Revision: D65802211
yuandagits
force-pushed
the
export-D65802211
branch
from
f6f6f32 to
524cfba
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65802211 |
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 12, 2024
Summary: Add ip_prefix function which takes in varchar or ipaddress along with a prefixBits. Use folly lib to convert the varchar or ipaddress type to folly::IPAddressV6, and then apply the mask. We return a tuple<int128_t, int8_t> which corresponds to the ipaddress and prefix for IPAddressPrefix type. Split from facebookincubator#11407 Differential Revision: D65802211
yuandagits
force-pushed
the
export-D65802211
branch
from
524cfba to
28fa3b3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65802211 |
yuandagits
force-pushed
the
export-D65802211
branch
from
28fa3b3 to
0ea750c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65802211 |
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 12, 2024
Summary: Add ip_prefix function which takes in varchar or ipaddress along with a prefixBits. Use folly lib to convert the varchar or ipaddress type to folly::IPAddressV6, and then apply the mask. We return a tuple<int128_t, int8_t> which corresponds to the ipaddress and prefix for IPAddressPrefix type. Split from facebookincubator#11407 Differential Revision: D65802211
yuandagits
force-pushed
the
export-D65802211
branch
from
0ea750c to
d60de75
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65802211 |
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 12, 2024
Summary: Add ip_prefix function which takes in varchar or ipaddress along with a prefixBits. Use folly lib to convert the varchar or ipaddress type to folly::IPAddressV6, and then apply the mask. We return a tuple<int128_t, int8_t> which corresponds to the ipaddress and prefix for IPAddressPrefix type. Split from facebookincubator#11407 Differential Revision: D65802211
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 15, 2024
Summary: Add ip_prefix function which takes in varchar or ipaddress along with a prefixBits. Use folly lib to convert the varchar or ipaddress type to folly::IPAddressV6, and then apply the mask. We return a tuple<int128_t, int8_t> which corresponds to the ipaddress and prefix for IPAddressPrefix type. Split from facebookincubator#11407 Differential Revision: D65802211
yuandagits
changed the title
|
This pull request was exported from Phabricator. Differential Revision: D65802211 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D65802211 |
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Dec 12, 2024
Summary: Pull Request resolved: facebookincubator#11514 Add ip_prefix function which takes in varchar or ipaddress along with a prefixBits. Use folly lib to convert the varchar or ipaddress type to folly::IPAddressV6, and then apply the mask. We return a tuple<int128_t, int8_t> which corresponds to the ipaddress and prefix for IPAddressPrefix type. Split from facebookincubator#11407 Reviewed By: spershin Differential Revision: D65802211
yuandagits
force-pushed
the
export-D65802211
branch
2 times, most recently
from
8f4c540 to
3d27e3a
Compare
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Dec 12, 2024
Summary: Pull Request resolved: facebookincubator#11514 Add ip_prefix function which takes in varchar or ipaddress along with a prefixBits. Use folly lib to convert the varchar or ipaddress type to folly::IPAddressV6, and then apply the mask. We return a tuple<int128_t, int8_t> which corresponds to the ipaddress and prefix for IPAddressPrefix type. Split from facebookincubator#11407 Reviewed By: spershin Differential Revision: D65802211
|
This pull request was exported from Phabricator. Differential Revision: D65802211 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D65802211 |
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Dec 13, 2024
Summary: Pull Request resolved: facebookincubator#11514 Add ip_prefix function which takes in varchar or ipaddress along with a prefixBits. Use folly lib to convert the varchar or ipaddress type to folly::IPAddressV6, and then apply the mask. We return a tuple<int128_t, int8_t> which corresponds to the ipaddress and prefix for IPAddressPrefix type. Split from facebookincubator#11407 Reviewed By: spershin Differential Revision: D65802211
yuandagits
force-pushed
the
export-D65802211
branch
from
3d27e3a to
77de4ac
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65802211 |
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Dec 16, 2024
Summary: Pull Request resolved: facebookincubator#11514 Add ip_prefix function which takes in varchar or ipaddress along with a prefixBits. Use folly lib to convert the varchar or ipaddress type to folly::IPAddressV6, and then apply the mask. We return a tuple<int128_t, int8_t> which corresponds to the ipaddress and prefix for IPAddressPrefix type. Split from facebookincubator#11407 Reviewed By: spershin Differential Revision: D65802211
yuandagits
force-pushed
the
export-D65802211
branch
from
77de4ac to
37b0e55
Compare
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Dec 16, 2024
Summary: Pull Request resolved: facebookincubator#11514 Add ip_prefix function which takes in varchar or ipaddress along with a prefixBits. Use folly lib to convert the varchar or ipaddress type to folly::IPAddressV6, and then apply the mask. We return a tuple<int128_t, int8_t> which corresponds to the ipaddress and prefix for IPAddressPrefix type. Split from facebookincubator#11407 Reviewed By: spershin Differential Revision: D65802211
yuandagits
force-pushed
the
export-D65802211
branch
from
37b0e55 to
f735792
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65802211 |
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Dec 18, 2024
Summary: Add ip_prefix function which takes in varchar or ipaddress along with a prefixBits. Use folly lib to convert the varchar or ipaddress type to folly::IPAddressV6, and then apply the mask. We return a tuple<int128_t, int8_t> which corresponds to the ipaddress and prefix for IPAddressPrefix type. Split from facebookincubator#11407 Reviewed By: xiaoxmeng, spershin Differential Revision: D65802211
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Dec 19, 2024
Summary: Add ip_prefix function which takes in varchar or ipaddress along with a prefixBits. Use folly lib to convert the varchar or ipaddress type to folly::IPAddressV6, and then apply the mask. We return a tuple<int128_t, int8_t> which corresponds to the ipaddress and prefix for IPAddressPrefix type. Split from facebookincubator#11407 Reviewed By: xiaoxmeng, spershin Differential Revision: D65802211
yuandagits
force-pushed
the
export-D65802211
branch
from
f735792 to
861f388
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65802211 |
Summary: Add ip_prefix function which takes in varchar or ipaddress along with a prefixBits. Use folly lib to convert the varchar or ipaddress type to folly::IPAddressV6, and then apply the mask. We return a tuple<int128_t, int8_t> which corresponds to the ipaddress and prefix for IPAddressPrefix type. Split from facebookincubator#11407 Reviewed By: xiaoxmeng, spershin Differential Revision: D65802211
yuandagits
force-pushed
the
export-D65802211
branch
from
861f388 to
1d594da
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65802211 |
|
This pull request has been merged in 6779ae7. |
athmaja-n
pushed a commit
to athmaja-n/velox
that referenced
this pull request
Jan 10, 2025
Summary: Pull Request resolved: facebookincubator#11514 Add ip_prefix function which takes in varchar or ipaddress along with a prefixBits. Use folly lib to convert the varchar or ipaddress type to folly::IPAddressV6, and then apply the mask. We return a tuple<int128_t, int8_t> which corresponds to the ipaddress and prefix for IPAddressPrefix type. Split from facebookincubator#11407 Reviewed By: xiaoxmeng, spershin Differential Revision: D65802211 fbshipit-source-id: ff0611c7c9aa8fd5057a11d84ecc50ca342ca037
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add ip_prefix function which takes in varchar or ipaddress along with a prefixBits.
Use folly lib to convert the varchar or ipaddress type to folly::IPAddressV6, and then apply the mask.
We return a tuple<int128_t, int8_t> which corresponds to the ipaddress and prefix for IPAddressPrefix type.
Split from #11407
Differential Revision: D65802211