This repository has been archived by the owner on Dec 13, 2018. It is now read-only.
Combine icon & kind in Outline View into a unified styleable property #1182
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now there is a .icon property which maps to Atom$Icons which doesn't have the icons we really want as well as a .kind property for theming I added.
This unifies the two - my new LSP-compatible icons are mapped to type-x where x is the kind property from LSP.
Should be no migration problems now as this preserves existing icon behavior for nuclide/those that used it and my usage from atom-languageclient of the now-removed kind had no impact yet.