pzstd: use # directly for the test c++ snippet #3681
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
\043 is not portable between shells: dash expands it to #, bash does not. As far as I see, using # works totally fine.
|
Make isn't cooperative either, 4.3 is fine with #, 4.2 wants backslash-#. Let's just read the test snippet from an external file. |
kanavin
pushed a commit
to kanavin/zstd
that referenced
this pull request
Jun 19, 2023
Doing this check with a direct c++ snippet is prone to portability problems: - \043 is not portable between shells: dash expands it to #, bash does not; - using # directly works with make 4.3 but does not with make 4.2. Let's just use the c++ version that covers both the code and the gtest. Upstream-Status: Submitted [facebook#3681] Signed-off-by: Alexander Kanavin <[email protected]> %% original patch: 0001-pzstd-use-directly-for-the-test-c-snippet.patch
|
Superseded by #3682 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
\043 is not portable between shells: dash expands it to #, bash does not. As far as I see, using # works totally fine.