Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[compiler][be] Clean up bug + feature test fixtures #31812

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -90,4 +90,6 @@ export const FIXTURE_ENTRYPOINT = {
};

```


### Eval output
(kind: ok) <div>{"shouldInvokeFns":true,"callback":{"kind":"Function","result":null}}</div>
Original file line number Diff line number Diff line change
@@ -85,4 +85,7 @@ export const FIXTURE_ENTRYPOINT = {
};

```


### Eval output
(kind: ok) {}
[[ (exception in render) TypeError: Cannot read properties of null (reading 'title_text') ]]
Original file line number Diff line number Diff line change
@@ -70,4 +70,8 @@ export const FIXTURE_ENTRYPOINT = {
};

```


### Eval output
(kind: ok) [[ (exception in render) TypeError: Cannot read properties of null (reading 'b') ]]
<div>{"fn":{"kind":"Function","result":null},"shouldInvokeFns":true}</div>
<div>{"fn":{"kind":"Function","result":4},"shouldInvokeFns":true}</div>
Original file line number Diff line number Diff line change
@@ -70,4 +70,9 @@ export const FIXTURE_ENTRYPOINT = {
};

```


### Eval output
(kind: ok) ["null"]
[null]
[null]
["null"]
13 changes: 3 additions & 10 deletions compiler/packages/snap/src/SproutTodoFilter.ts
Original file line number Diff line number Diff line change
@@ -477,22 +477,15 @@ const skipFilter = new Set([
'invalid-jsx-lowercase-localvar',

// bugs
'fbt/bug-fbt-plural-multiple-function-calls',
'fbt/bug-fbt-plural-multiple-mixed-call-tag',
`bug-capturing-func-maybealias-captured-mutate`,
'bug-object-expression-computed-key-modified-during-after-construction-hoisted-sequence-expr',
'bug-invalid-hoisting-functionexpr',
`bug-capturing-func-maybealias-captured-mutate`,
'bug-aliased-capture-aliased-mutate',
'bug-aliased-capture-mutate',
'bug-functiondecl-hoisting',
'bug-try-catch-maybe-null-dependency',
'bug-type-inference-control-flow',
'reduce-reactive-deps/bug-infer-function-cond-access-not-hoisted',
'fbt/bug-fbt-plural-multiple-function-calls',
'fbt/bug-fbt-plural-multiple-mixed-call-tag',
'bug-invalid-phi-as-dependency',
'reduce-reactive-deps/bug-merge-uncond-optional-chain-and-cond',
'original-reactive-scopes-fork/bug-nonmutating-capture-in-unsplittable-memo-block',
'original-reactive-scopes-fork/bug-hoisted-declaration-with-scope',
'bug-codegen-inline-iife',

// 'react-compiler-runtime' not yet supported
'flag-enable-emit-hook-guards',