Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-compiler): implement NumericLiteral as ObjectPropertyKey #31791

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update test to see object with numeric key in output
dimaMachina committed Dec 15, 2024
commit 59f2dd157d55adf7fc6c85ce77a140f6939967d0
Original file line number Diff line number Diff line change
@@ -6,7 +6,7 @@ function Test() {
const obj = {
21: 'dimaMachina'
}
return <div />
return <div>{obj[21]}</div>
}

```
@@ -19,7 +19,9 @@ function Test() {
const $ = _c(1);
let t0;
if ($[0] === Symbol.for("react.memo_cache_sentinel")) {
t0 = <div />;
const obj = { 21: "dimaMachina" };

t0 = <div>{obj[21]}</div>;
$[0] = t0;
} else {
t0 = $[0];
@@ -30,4 +32,4 @@ function Test() {
```

### Eval output
(kind: exception) Fixture not implemented
(kind: exception) Fixture not implemented
Original file line number Diff line number Diff line change
@@ -2,5 +2,5 @@ function Test() {
const obj = {
21: 'dimaMachina'
}
return <div />
return <div>{obj[21]}</div>
}