Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove enableFilterEmptyStringAttributesDOM #31765

Merged
merged 3 commits into from
Dec 13, 2024
Merged

Remove enableFilterEmptyStringAttributesDOM #31765

merged 3 commits into from
Dec 13, 2024

Conversation

rickhanlonii
Copy link
Member

Base off #31764

This has landed everywhere

@vercel Vercel
Copy link

vercel bot commented Dec 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 8:55pm

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Dec 13, 2024
@rickhanlonii rickhanlonii mentioned this pull request Dec 13, 2024
Merged
sebmarkbage
sebmarkbage approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@sebmarkbage sebmarkbage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed a bug with this today. Empty href string doesn't hydrate on the client since the attribute is omitted from the server. Causing a hydration error (in addition to the warning).

@react-sizebot
Copy link

Comparing: 3ad17ec...fda9cd7

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 510.34 kB 510.34 kB = 91.32 kB 91.33 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 515.25 kB 515.25 kB = 92.02 kB 92.02 kB
facebook-www/ReactDOM-prod.classic.js = 595.18 kB 595.18 kB = 105.01 kB 105.01 kB
facebook-www/ReactDOM-prod.modern.js = 585.44 kB 585.44 kB = 103.45 kB 103.45 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against ad3968d

sebmarkbage
sebmarkbage reviewed Dec 13, 2024
View reviewed changes
packages/react-dom-bindings/src/client/ReactDOMComponent.js
'or pass null to %s instead of an empty string.',
propKey,
propKey,
);
}
Copy link
Collaborator

@sebmarkbage sebmarkbage Dec 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should probably skip hydrateSanitizedAttribute below if we already warned above.

I.e. call continue in the branch above.

Otherwise we end up both logging the error and with a hydration error, because the server will have omitted this attribute.

The hydration error is also not correct because it's not what the client would've done.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean only in the DEV branch above? That seems weird to differ in behavior?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think what you're saying is that this would be how to fix the bug you found, so i'll merge with the existing behavior and we can fix the bug in a follow up

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well the DEV branch is defensive. This whole function is inside a DEV branch so it's not divergent.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#31783

@rickhanlonii rickhanlonii merged commit 4996a8f into facebook:main Dec 13, 2024
187 checks passed
@rickhanlonii rickhanlonii deleted the rh/rm-ff-filter-strings branch December 13, 2024 21:30
github-actions bot pushed a commit that referenced this pull request Dec 13, 2024
@rickhanlonii
Remove enableFilterEmptyStringAttributesDOM (#31765)
e67f32f 
Base off #31764

This has landed everywhere

DiffTrain build for [4996a8f](4996a8f)
github-actions bot pushed a commit that referenced this pull request Dec 13, 2024
@rickhanlonii
Remove enableFilterEmptyStringAttributesDOM (#31765)
ed63850 
Base off #31764

This has landed everywhere

DiffTrain build for [4996a8f](4996a8f)
rickhanlonii added a commit that referenced this pull request Dec 13, 2024
@rickhanlonii
Remove enableFlightReadableStream (#31766)
1520802 
Base: #31765

Landed everywhere
github-actions bot pushed a commit to code/lib-react that referenced this pull request Dec 14, 2024
@pull
Remove enableFlightReadableStream (facebook#31766)
e7358eb 
Base: facebook#31765

Landed everywhere

DiffTrain build for [1520802](facebook@1520802)
github-actions bot pushed a commit to code/lib-react that referenced this pull request Dec 14, 2024
@pull
Remove enableFlightReadableStream (facebook#31766)
051ef83 
Base: facebook#31765

Landed everywhere

DiffTrain build for [1520802](facebook@1520802)
@rickhanlonii rickhanlonii mentioned this pull request Dec 14, 2024
Draft
This was referenced Dec 18, 2024
Closed
Closed
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebmarkbage sebmarkbage sebmarkbage approved these changes

@kassens kassens kassens approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rickhanlonii @react-sizebot @kassens @sebmarkbage @facebook-github-bot