Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IOS][NewArch] fix TextInput dataDetectorTypes #48952

Closed
wants to merge 4 commits into from
Closed

[IOS][NewArch] fix TextInput dataDetectorTypes #48952

wants to merge 4 commits into from
+59 −0

Conversation

VidocqH
Copy link
Contributor

@VidocqH VidocqH commented Jan 26, 2025

Summary:

Setting dataDetectorTypes has no effect. As I am new to the react native codebase, it seems like dataDetectorTypes has not implemented on new arch yet.

issue: #48951

Changelog:

[IOS] [FIXED] - implement dataDetectorTypes in the same way as the old architecture

Test Plan:

image

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Jan 26, 2025
cipolleschi
cipolleschi approved these changes Jan 26, 2025
View reviewed changes
Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this.
The code looks good, I left a quick question.

...ges/react-native/React/Fabric/Mounting/ComponentViews/TextInput/RCTTextInputComponentView.mm Show resolved Hide resolved
@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jan 28, 2025
@facebook-github-bot
Copy link
Contributor

@cipolleschi merged this pull request in 2ae45ec.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @VidocqH in 2ae45ec

When will my fix make it into a release? | How to file a pick request?

@VidocqH VidocqH deleted the feat(ios,new_arch)/input-data-detector branch January 28, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cipolleschi cipolleschi cipolleschi approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@VidocqH @facebook-github-bot @react-native-bot @cipolleschi