Refactor NetworkOverlay to use a symbol instead of a public property in XHR #48928
+20
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68625224 |
|
This pull request was exported from Phabricator. Differential Revision: D68625224 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 24, 2025
…in XHR (facebook#48928) Summary: Pull Request resolved: facebook#48928 Changelog: [internal] Just a minor change to reduce the number of Flow errors we will get when we refactor XHR soon. Differential Revision: D68625224
rubennorte
force-pushed
the
export-D68625224
branch
2 times, most recently
from
636aa27 to
c64f915
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 25, 2025
…in XHR (facebook#48928) Summary: Changelog: [internal] Just a minor change to reduce the number of Flow errors we will get when we refactor XHR soon. Differential Revision: D68625224
|
This pull request was exported from Phabricator. Differential Revision: D68625224 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 27, 2025
…in XHR (facebook#48928) Summary: Pull Request resolved: facebook#48928 Changelog: [internal] Just a minor change to reduce the number of Flow errors we will get when we refactor XHR soon. Differential Revision: D68625224
rubennorte
force-pushed
the
export-D68625224
branch
from
c64f915 to
fa9190b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68625224 |
rubennorte
force-pushed
the
export-D68625224
branch
from
fa9190b to
8c416b6
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 27, 2025
…in XHR (facebook#48928) Summary: Changelog: [internal] Just a minor change to reduce the number of Flow errors we will get when we refactor XHR soon. Differential Revision: D68625224
|
This pull request was exported from Phabricator. Differential Revision: D68625224 |
rubennorte
force-pushed
the
export-D68625224
branch
from
8c416b6 to
ba55cff
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 27, 2025
…in XHR (facebook#48928) Summary: Changelog: [internal] Just a minor change to reduce the number of Flow errors we will get when we refactor XHR soon. Differential Revision: D68625224
|
This pull request was exported from Phabricator. Differential Revision: D68625224 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 27, 2025
…in XHR (facebook#48928) Summary: Changelog: [internal] Just a minor change to reduce the number of Flow errors we will get when we refactor XHR soon. Reviewed By: javache Differential Revision: D68625224
rubennorte
force-pushed
the
export-D68625224
branch
from
ba55cff to
168ab3c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68625224 |
rubennorte
force-pushed
the
export-D68625224
branch
from
168ab3c to
a040aa0
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 28, 2025
…in XHR (facebook#48928) Summary: Changelog: [internal] Just a minor change to reduce the number of Flow errors we will get when we refactor XHR soon. Reviewed By: javache Differential Revision: D68625224
|
This pull request was exported from Phabricator. Differential Revision: D68625224 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 28, 2025
…in XHR (facebook#48928) Summary: Changelog: [internal] Just a minor change to reduce the number of Flow errors we will get when we refactor XHR soon. Reviewed By: javache Differential Revision: D68625224
rubennorte
force-pushed
the
export-D68625224
branch
from
a040aa0 to
3842356
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68625224 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 29, 2025
…in XHR (facebook#48928) Summary: Changelog: [internal] Just a minor change to reduce the number of Flow errors we will get when we refactor XHR soon. Reviewed By: javache Differential Revision: D68625224
rubennorte
force-pushed
the
export-D68625224
branch
from
3842356 to
45da01e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68625224 |
…in XHR (facebook#48928) Summary: Changelog: [internal] Just a minor change to reduce the number of Flow errors we will get when we refactor XHR soon. Reviewed By: javache Differential Revision: D68625224
rubennorte
force-pushed
the
export-D68625224
branch
from
45da01e to
2392fcb
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 29, 2025
… property in XHR (facebook#48928) Summary: Changelog: [internal] Just a minor change to reduce the number of Flow errors we will get when we refactor XHR soon. Reviewed By: javache Differential Revision: D68625224
|
This pull request was exported from Phabricator. Differential Revision: D68625224 |
|
This pull request was successfully merged by @rubennorte in 4ba0e79 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
Just a minor change to reduce the number of Flow errors we will get when we refactor XHR soon.
Differential Revision: D68625224