react-native\packages\react-native\Libraries\Blob\URL.js Changes

[bobbysharma05]

SUMMARY

The URL class was refactored to handle blob URLs more effectively, improving URL construction and parsing. Changes include better error handling in the createObjectURL method and the addition of functions to extract URL components like username, host, and protocol.

Changelog:

• Replaced static URL construction with dynamic initialization using NativeBlobModule.
• Enhanced createObjectURL with better validation and error handling.
• Added methods to extract URL components (username, host, protocol).
• Cleaned up unnecessary code for better readability.

Test Plan:

• Test createObjectURL with valid and invalid Blob data.
• Verify that URL components (hostname, pathname, etc.) are parsed correctly.
• Test integration with URLSearchParams for query handling.

[facebook-github-bot]

Hi @bobbysharma05!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[react-native-bot]

	Fails
🚫	📋 Verify Changelog Format - See Changelog format

Generated by 🚫 dangerJS against d4174f6

[cipolleschi]

Hi @bobbysharma05, thanks for working on this.
Could you please add a Summary explaining the changes and a Changelog in the PR, following the suggested structure?

[cipolleschi]

Code changes look good to me, but the PR is missing information in the Description.
We can't import without Summary, Changelog and TestPlan

[cipolleschi]

Also, the test_js signal is failing, can you have a look at it?

[bobbysharma05]

ok sir I will look into it and also add the summary.

[bobbysharma05]

Sir I am new to the open source. Could you please help me in which part I am getting stuck.

[cipolleschi]

When a new pr is open, we provide a template that has to be filled. For the Changelog, specifically, it has to follow a predefined format, which is described here.

For this pr, it should be something like:

[General][Fixed] -  implemented missing methods on URL.js

For the failures, you can click on the failed signals in the github UI and read through the logs, looking for the errors (the search function is your friend).

For example, the linter says that the community-cli-plugin has been built and it should not. If you inspect the changed files, you see that you committed a package.json that should not be committed.

The test_js says that there is an invalid expression at line 25 of the URL.js file.

Build_android failure is related to the failure for the linter, so it should be fixed by reverting the changes in the community-cli-plugin/package.json.