Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.76] Simplify key handling in start command #46645

Merged
merged 4 commits into from
Sep 30, 2024

Conversation

huntie
Copy link
Member

@huntie huntie commented Sep 25, 2024

Summary

Note

Depends on #46643 and #46644.

This is a 0.76 pick (eager) of D63255321. We're blocked from landing that PR on main first, as Metro is not yet released targeting main (we're in a temporary state with alpha releases for 0.76).

Remove the KeyPressHandler util in favour of using the process.stdin APIs inline.

This reduces complexity (where we were effectively not using the conditional interception this previously implemented — see also #46416), and more closely mirrors our internal dev server setup.

Resolves #46571.

Changelog:
[General][Fixed] - Fix unresponsive CLI key commands after triggering j to debug

Test Plan

(Includes test cases for #46644.)

🎬: https://pxl.cl/5F5sH

✅ Logs sent via new Metro reporter events
j to debug target selection menu is functional
✅ Key commands continue to be handled (no longer blocked after first debugger launch)

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Sep 25, 2024
@react-native-bot
Copy link
Collaborator

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against ca5d9b3

Copy link
Contributor

@blakef blakef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't merge this, we will do that as part of the pick.

LGTM, one minor question about the raw mode.

Copy link
Contributor

@blakef blakef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking as Request Changes to block until Monday, but it's GTG.

@blakef blakef merged commit 5a0df6d into facebook:0.76-stable Sep 30, 2024
4 of 9 checks passed
@huntie huntie deleted the 0.76-fix-cli-key-handling branch October 15, 2024 10:28
@blakef blakef mentioned this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants