Animated: Store Listeners w/ Map #46372
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Pull Request resolved: facebook#46312 Refactors `NativeAnimatedHelper` to make it easier to read, reduce runtime overhead, and no longer export `queueOperation` (which was not useable externally anyway). Changelog: [Internal] Reviewed By: javache Differential Revision: D62139993
Summary: Pull Request resolved: facebook#46286 Optimizes the runtime performance of `Animated` by using memoization to avoid repetitive traversals of `props` (and `style`) values. Changelog: [General][Changed] - Improved runtime performance of `Animated` Reviewed By: javache Differential Revision: D62037506
Summary: Currently, `AnimatedNode.prototype.getListeners` creates an array with `Object.keys()` to determine the number of listeners. This is a relatively hot code path for animation-intensive user interfaces. Although `Object.keys()` is fast, every unnecessary memory allocation is an unnecessary opportunity to create garbage that requires collection. Using an object as a dictionary performs worst than using a `Map` anyway, so this switches `AnimatedNode` to use a `Map`. Changelog: [Internal] Reviewed By: javache Differential Revision: D62267352
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62267352 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Currently,
AnimatedNode.prototype.getListenerscreates an array withObject.keys()to determine the number of listeners.This is a relatively hot code path for animation-intensive user interfaces. Although
Object.keys()is fast, every unnecessary memory allocation is an unnecessary opportunity to create garbage that requires collection.Using an object as a dictionary performs worst than using a
Mapanyway, so this switchesAnimatedNodeto use aMap.Changelog:
[Internal]
Reviewed By: javache
Differential Revision: D62267352