-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(website): Upgrade to Docusaurus v3.6 - Enable Docusaurus Faster #4268
Conversation
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Docusaurus v3.6 is out - PR updated Blog post coming: https://docusaurus.io/blog/releases/3.6 @Simek ready to review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on the upgrade, tested locally, LGTM! 👍
Nice catch Nico! 👍 Found out that our CSS variable reassignment has been superseded by Pushed a small fix for that, and also updated the lock after switching from pre-release to stable Docusuars version. |
nice catch thanks Switching for cssnano to lightningcss might have some subtle effects on CSS order. Previously our optimizer was a bit too aggressive/unsafe and removing that aggressivity (that doesn't even exist in lightnings) might change some rules being applied. If you want more confidence than manual review, I can run my visual regression tests on the PR, similarly to what I did for the Docusaurus v3 upgrade here #3780 |
Yeah that would be nice if is not too much work |
I'll do that on Thursday when I'm back on Docusaurus 👍 Yes, it's additional manual work for me because Argos CI is not installed on this repo and I have to work around that using a separate test repo. In the future, if you want to have visual regression tests simply by adding a PR label on a PR, you could adopt this CI workflow: https://docusaurus.io/blog/upgrading-frontend-dependencies-with-confidence-using-visual-regression-testing I suggested it on Discord already but not sure who is supposed to make the decision. The question is: is it worth it? |
I guess our primary use cases would be significant version bumps like this one. We rarely do site-wide changes that are hard to check if regressing from a preview |
If I'm the only one doing these bumps, it's probably useless then. If others do it, it may be useful. Visual regression tests here: PR: slorber/rnw-visual-tests#9 Only one change reported: Report: https://app.argos-ci.com/slorber/rnw-visual-tests/builds/75/117730262 Note: this is a false positive and happens because this page has a snack player input autofocus that makes the page scroll: https://reactnative.dev/docs/improvingux So, it looks safe to merge 👍 |
Docusaurus Faster should allow the React Native Website to build... faster.
Benchmarks
Cold build:
Site builds 3x+ faster on cold builds.
Warm build
About the same time for warm rebuilds, despite the lack of persistent caching (see facebook/docusaurus#10556). Rspack also outperforms