Janga: config: Adjusted sensor related thresholds #523
+198
−213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhongedward
force-pushed
the
janga_optimize_sensor_thresholds_8_25
branch
from
7231318 to
60db527
Compare
|
@mikechoifb has imported this pull request. If you are a Meta employee, you can view this in D81607205. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is for janga sensor service config file.
Motivation
1.In this PR, the sensor-related thresholds are adjusted according to the table provided by the latest hardware.The main changes are the sensor thresholds of the SMB board and the sensor thresholds of the COME board.
2.Fixed the issue that the
minAlarmValandmaxAlarmValthresholds ofSMB_U360_XP1R5V_SW_PLL_PVDD_A_VOLTandSMB_U360_XP1R5V_SW_VDDH_A_VOLTare the same.3.Bumped bspKmodsRpmVersion to
3.3.0-1in platform_manager.json.Test Plan
1.The correctness of the format has been verified on this jsonlint website.
2.Used jq command to pretty the format.
3.Compilation and multiple services configs cross-check passed.
In main source machine tested pass:
LD_LIBRARY_PATH=./lib/ ./sensor_service_hw_test --config_file sensor_service.json --logging=DBG5
In 2nd source machine tested pass:
LD_LIBRARY_PATH=./lib/ ./sensor_service_hw_test --config_file sensor_service.json --logging=DBG5
Test log:
janga_main_source_pm_test_log_8_19.txt
janga_main_source_sensor_test_log_8_25_6th.txt
janga_main_source_fan_test_log_8_19.txt
janga_2nd_source_pm_test_log_8_19.txt
janga_2nd_source_sensor_test_log_8_25_6th.txt
janga_2nd_source_fan_test_log_8_19.txt