Darwin: bsp mapping #420
Open
Darwin: bsp mapping #420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -108,6 +110,20 @@ std::unique_ptr<WedgeManager> createWedgeManager() { | |||
| return std::make_unique<Wedge40Manager>(platformMappingStr); | |||
| } | |||
|
|
|||
| std::unique_ptr<WedgeManager> createDarwinWedgeManager( | |||
There was a problem hiding this comment.
We need to have a boolean gflag (use_bsp_access), disabled by default so that we don't change our current prod behavior (accessing transceivers through userspace i2c drivers). You can enable that flag in your config and test this. We'll enable it slowly in prod once we are ready to roll out BSP access for Darwin
There was a problem hiding this comment.
Just to clarify. This flag doesn't exist and need to be defined and default to false. Which platforms need to set this flag to true and where is that done?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fboss/led_service/oss/DarwinLedManager.cppstill exists, it wasn't removed as its unknown what the side effects are on non-oss systems.Depends on:
Testing
sai agent hwtests