Skip to content

integrate last change time into external_update_time calculation #3577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rithikb24 wants to merge 1 commit into from
Closed

integrate last change time into external_update_time calculation #3577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions includes/fbproduct.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2248,9 +2248,17 @@ public function prepare_product( $retailer_id = null, $type_to_prepare_for = sel
$product_data['gtin'] = $this->woo_product->get_global_unique_id();
}

if ( $this->woo_product->get_date_modified() ) {
$date_modified = $this->woo_product->get_date_modified();
$product_data['external_update_time'] = $date_modified->getTimestamp();
$date_modified = $this->woo_product->get_date_modified();
if ( $date_modified ) {
$external_update_time = (int) $date_modified->getTimestamp();
$last_change_time = (int) $this->woo_product->get_meta( '_last_change_time' );

// Use the newer timestamp if _last_change_time is valid, otherwise use external_update_time
if ( $last_change_time > 0 ) {
$product_data['external_update_time'] = max( $external_update_time, $last_change_time );
} else {
$product_data['external_update_time'] = $external_update_time;
}
}

// Only use checkout URLs if they exist.
Expand Down
169 changes: 169 additions & 0 deletions tests/Unit/UpdateLastChangeTimeTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,169 @@
<?php
/**
* Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved
*
* This source code is licensed under the license found in the
* LICENSE file in the root directory of this source tree.
*
* @package FacebookCommerce
*/

require_once __DIR__ . '/../../facebook-commerce.php';

use PHPUnit\Framework\TestCase;

/**
* Tests for the updated last change time functionality
*/
class UpdateLastChangeTimeTest extends TestCase {

private $integration;
private $facebook_for_woocommerce;

public function setUp(): void {
parent::setUp();

// Create minimal mocks for the integration constructor
$this->facebook_for_woocommerce = $this->createMock(WC_Facebookcommerce::class);

// Mock rollout switches to prevent initialization issues
$rollout_switches = $this->createMock(WooCommerce\Facebook\RolloutSwitches::class);
$rollout_switches->method('is_switch_enabled')->willReturn(false);
$this->facebook_for_woocommerce->method('get_rollout_switches')->willReturn($rollout_switches);

// Create integration instance for testing the refactored methods
$this->integration = new WC_Facebookcommerce_Integration($this->facebook_for_woocommerce);
}

/**
* Test: Core last change time flow
* Tests main entry point, validation, and update mechanisms
*/
public function test_core_last_change_time_flow() {
// Test main entry point with edge cases
$edge_cases = [
[0, 0, '', null], // Empty values
[1, 999999, 'normal_key', 'value'], // Non-existent product
[1, 123, '_last_change_time', 'value'], // Self-referential (should be excluded)
];

foreach ($edge_cases as [$meta_id, $product_id, $meta_key, $meta_value]) {
try {
$this->integration->update_product_last_change_time($meta_id, $product_id, $meta_key, $meta_value);
$this->assertTrue(true, 'update_product_last_change_time handled edge case gracefully');
} catch (Exception $e) {
$this->assertTrue(true, 'update_product_last_change_time properly caught exception');
}
}

// Test validation methods using reflection for private method
$reflection = new \ReflectionClass($this->integration);
$validation_method = $reflection->getMethod('should_update_product_change_time');
$validation_method->setAccessible(true);

$this->assertFalse(
$validation_method->invoke($this->integration, 123, 'irrelevant_meta'),
'should_update_product_change_time rejects irrelevant meta keys'
);

$this->assertFalse(
$validation_method->invoke($this->integration, 123, '_last_change_time'),
'should_update_product_change_time rejects self-referential updates'
);

// Test core update mechanism
$reflection = new \ReflectionClass($this->integration);
$update_method = $reflection->getMethod('perform_product_last_change_time_update');
$update_method->setAccessible(true);

try {
$update_method->invoke($this->integration, 123);
$this->assertTrue(true, 'perform_product_last_change_time_update executes without errors');
} catch (Exception $e) {
$this->fail('perform_product_last_change_time_update should not throw exceptions: ' . $e->getMessage());
}
}

/**
* Test: Meta key filtering logic
* Tests which meta keys should trigger sync updates
*/
public function test_meta_key_filtering() {
$reflection = new \ReflectionClass($this->integration);
$method = $reflection->getMethod('is_product_attribute_sync_relevant');
$method->setAccessible(true);

// Should EXCLUDE these keys
$excluded_keys = [
'_last_change_time', '_fb_sync_last_time', // Prevent infinite loops
'_wp_attached_file', '_edit_last', // WordPress internals
'custom_field', 'other_plugin_meta' // Unrelated meta
];

foreach ($excluded_keys as $key) {
$this->assertFalse(
$method->invoke($this->integration, $key),
"Should exclude key: {$key}"
);
}

// Should INCLUDE these keys (trigger sync)
$sync_relevant_keys = [
'_regular_price', '_sale_price', '_stock', '_stock_status', // WooCommerce core
'fb_brand', 'fb_color', 'fb_size', 'fb_product_condition', // Facebook attributes
'_wc_facebook_sync_enabled' // Facebook settings
];

foreach ($sync_relevant_keys as $key) {
$this->assertTrue(
$method->invoke($this->integration, $key),
"Should include key: {$key}"
);
}
}

/**
* Test: Rate limiting functionality
* Tests that updates are properly rate-limited to prevent spam
*/
public function test_rate_limiting() {
$reflection = new \ReflectionClass($this->integration);
$rate_limited_method = $reflection->getMethod('is_last_change_time_update_rate_limited');
$rate_limited_method->setAccessible(true);

$cache_method = $reflection->getMethod('set_last_change_time_cache');
$cache_method->setAccessible(true);

$product_id = 456;

// Initially not rate limited
$this->assertFalse(
$rate_limited_method->invoke($this->integration, $product_id),
'Should not be rate limited initially'
);

// Set cache with current time - should now be rate limited
$current_time = time();
$cache_method->invoke($this->integration, $product_id, $current_time);
$this->assertTrue(
$rate_limited_method->invoke($this->integration, $product_id),
'Should be rate limited after setting cache'
);

// Set cache with old time (beyond 60s window) - should not be rate limited
$old_time = $current_time - 120;
$cache_method->invoke($this->integration, $product_id, $old_time);
$this->assertFalse(
$rate_limited_method->invoke($this->integration, $product_id),
'Should not be rate limited after cache expires'
);

// Test cache setting doesn't throw exceptions
try {
$cache_method->invoke($this->integration, $product_id, time());
$this->assertTrue(true, 'set_last_change_time_cache executes without errors');
} catch (Exception $e) {
$this->fail('set_last_change_time_cache should not throw exceptions: ' . $e->getMessage());
}
}
}
Loading