Skip to content

Conversation

ukilla
Copy link
Collaborator

@ukilla ukilla commented Jul 24, 2025

Description

This PR improves product sync visibility by marking products with sync issues (stored in _fb_sync_issues) as "Not synced" in the admin product list. These products won't be synced to the Meta catalog and therefore won't appear in the shop. A tooltip explains the reason.

Implements better filtering and display behavior as discussed in issue #3519.

Type of change

Please delete options that are not relevant

  • Add (non-breaking change which adds functionality)

Checklist

  • I have commented my code, particularly in hard-to-understand areas, if any.
  • I have confirmed that my changes do not introduce any new PHPCS warnings or errors.
  • I have checked plugin debug logs that my changes do not introduce any new PHP warnings or FATAL errors.
  • I followed general Pull Request best practices. Meta employees to follow this wiki.
  • I have added tests (if necessary) and all the new and existing unit tests pass locally with my changes.
  • I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality.
  • I have updated or requested update to plugin documentations (if necessary). Meta employees to follow this wiki.

Changelog entry

Mark products with sync issues as “Not synced” in the product list with explanatory tooltip

Test Plan

  1. Create or edit a product and intentionally add a condition that will cause a sync validation failure (e.g. leave required fields empty)
  2. Go to plugin settings -> Product sync -> Sync products
  3. Navigate to Products -> All Products in the WordPress admin and locate the affected product in the product list.
  4. Ensure it shows as “Not synced” in the “Synced to Meta catalog” column.
  5. Hover over the question mark tooltip and verify that the sync error message is shown.
  6. Use the “Filter by synced to Meta” dropdown to select “Not synced”.
  7. Confirm only products with sync issues appear.
  8. Select “Synced” and verify that only synced products are listed.

@ukilla ukilla added the changelog: add A new feature, function, or functionality was added. label Jul 24, 2025
Copy link
Contributor

github-actions bot commented Jul 24, 2025

📦 Latest Plugin Build

Built at: 2025-07-29T10:50:10.420Z
Commit: 597fefd
Size: 1.1M

Download: Click here to download the plugin

To download: Click the link above → Scroll to bottom → Download "facebook-for-woocommerce" artifact

@iodic iodic self-requested a review July 24, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: add A new feature, function, or functionality was added. CLA Signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants