feat: poc generated image #10432
Draft
feat: poc generated image #10432
+68
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: -8.67 kB (-0.07%) Total Size: 11.6 MB
ℹ️ View Unchanged
|
|
I would prefer a more simplistic solution by default without the gradient background—what about just gray background and the initial letters? |
|
Here is what grey images look like (also included the random gradiant with multiple authors) |
|
I find the grey variant better and sober, more in sync with our theme 👍 Maybe it could be interesting to add a small grey-only gradient? Also could you add:
|
slorber
added
pr: new feature
slorber
requested changes
Aug 26, 2024
packages/docusaurus-theme-classic/src/theme/Blog/Components/Author/styles.module.css
Outdated
Show resolved
Hide resolved
packages/docusaurus-theme-classic/src/theme/Blog/Components/Author/GeneratedImage/index.tsx
Outdated
Show resolved
Hide resolved
packages/docusaurus-theme-classic/src/theme/Blog/Components/Author/GeneratedImage/index.tsx
Outdated
Show resolved
Hide resolved
packages/docusaurus-theme-classic/src/theme/Blog/Components/Author/GeneratedImage/index.tsx
Outdated
Show resolved
Hide resolved
packages/docusaurus-theme-classic/src/theme/Blog/Components/Author/GeneratedImage/index.tsx
Outdated
Show resolved
Hide resolved
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
|
Wonder what a blog post with inline authors with no image should look like. For example this case:
IMHO it looks better after, but not sure it's what users expect us to do. I think we should keep the ability to display authors' names without avatars? In particular for single author blogs that don't care about avatar or author layout alignment.
At least, if none of the authors have any avatar, maybe we shouldn't add the extra avatar because all users would have generated avatars? Or maybe this should be an opt-in theme option? What do you think @Josh-Cena @OzakIOne ? |
|
Personally, I don't like the way it looks when there are no images, so I'm in favor of enabling this by default however users may not want this. |
|
I'm ambivalent. I find the current no-avatar rendering quite ugly, but maybe it's better if there's a subtitle line. I also think the current one is a good default and users can always either swizzle or use CSS to provide something better. After all, everything about rendering is up to Docusaurus to decide. If you really want to, we can make this opt-in and then remove the option in v4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Idea in #10427
Test Plan
Deploy
Test links
Deploy preview: https://deploy-preview-10432--docusaurus-2.netlify.app/tests/blog/authors