Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[py-tx] Add a new match command line option (--rotations) #1672

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

[py-tx] Add a new match command line option (--rotations) #1672

wants to merge 18 commits into from
+128 −19

Commits on Oct 28, 2024

  1. Create RotationType enum

    @haianhng31
    haianhng31 committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    26fe246 View commit details
    Browse the repository at this point in the history

  2. Create rotation helpers for PhotoContent

    @haianhng31
    haianhng31 committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    931b81a View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Include docstring and comments

    @haianhng31
    haianhng31 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    dfe04d9 View commit details
    Browse the repository at this point in the history

  2. Create --rotation command line

    @haianhng31
    haianhng31 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    0e44874 View commit details
    Browse the repository at this point in the history

  3. Fix lint and small change to photo rotation helpers

    @haianhng31
    haianhng31 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    bd532ae View commit details
    Browse the repository at this point in the history

  4. Merge branch 'photo-helpers' of https://github.com/haianhng31/ThreatE… 

    …xchange into rotation-cmd

Merge the new commits from photo-helpers branch to this branch.
    @haianhng31
    haianhng31 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    13bf6e7 View commit details
    Browse the repository at this point in the history

  5. create dataclass IndexMatchWithRotation and use that in match_cmd

    @haianhng31
    haianhng31 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    594782b View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. Merge branch 'main' into rotation-cmd

    @haianhng31
    haianhng31 authored Nov 1, 2024
    Configuration menu
    Copy the full SHA
    f8a5891 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2024

  1. merge main

    @haianhng31
    haianhng31 committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    e570ef9 View commit details
    Browse the repository at this point in the history

  2. edit _IndexMatchWithRotation and updates its usage in match_cmd

    @haianhng31
    haianhng31 committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    02ff144 View commit details
    Browse the repository at this point in the history

  3. add --rotations to hash cmd

    @haianhng31
    haianhng31 committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    a9db9d9 View commit details
    Browse the repository at this point in the history

  4. Minor fix to hash cmd

    @haianhng31
    haianhng31 committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    ad9a165 View commit details
    Browse the repository at this point in the history

  5. fix small detail in hash cmd

    @haianhng31
    haianhng31 committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    a1a39d3 View commit details
    Browse the repository at this point in the history

  6. Add test cases for Hash command with rotations

    @haianhng31
    haianhng31 committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    6a6cea0 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. fix minor details & remove old test cases for hash with rotations

    @haianhng31
    haianhng31 committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    d841f60 View commit details
    Browse the repository at this point in the history

  2. checkout hash_cmd.py from main (hash_cmd --rotations is handled in a … 

    …different PR)
    @haianhng31
    haianhng31 committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    3b83a41 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. Merge branch 'main' of https://github.com/facebook/ThreatExchange int… 

    …o rotation-cmd
    @haianhng31
    haianhng31 committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    dff8c1b View commit details
    Browse the repository at this point in the history

  2. match rotation tests

    @haianhng31
    haianhng31 committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    e367f61 View commit details
    Browse the repository at this point in the history