Migration to Noise module #4761
Open
+134
−285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4761 +/- ##
==========================================
- Coverage 96.73% 96.71% -0.02%
==========================================
Files 585 585
Lines 61196 61122 -74
==========================================
- Hits 59195 59113 -82
- Misses 2001 2009 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Jan 13, 2026
Summary: Updates `benchmark.py` to use the new Noise module architecture: passes `problem.noise` instead of `problem.noise_std` to `BenchmarkRunner`, and removes the obsolete `add_custom_noise` replacement since noise is now handled entirely by the `Noise` object on the runner. Differential Revision: D90597013
hvarfner
force-pushed
the
export-D90597013
branch
from
b35679b to
f3c643c
Compare
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Jan 14, 2026
Summary: Updates `benchmark.py` to use the new Noise module architecture: - passes `problem.noise` instead of `problem.noise_std` to `BenchmarkRunner` - removes the obsolete `add_custom_noise` replacement since noise is now handled entirely by the `Noise` object on the runner. - Kept `noise_std` argument around to ensure backwards compatibility. Differential Revision: D90597013
hvarfner
force-pushed
the
export-D90597013
branch
from
f3c643c to
526163e
Compare
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Jan 14, 2026
Summary: Pull Request resolved: facebook#4761 Updates `benchmark.py` to use the new Noise module architecture: - passes `problem.noise` instead of `problem.noise_std` to `BenchmarkRunner` - removes the obsolete `add_custom_noise` replacement since noise is now handled entirely by the `Noise` object on the runner. - Kept `noise_std` argument around to ensure backwards compatibility. Differential Revision: D90597013
hvarfner
force-pushed
the
export-D90597013
branch
from
526163e to
0b574ab
Compare
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Jan 14, 2026
Summary: Updates `benchmark.py` to use the new Noise module architecture: - passes `problem.noise` instead of `problem.noise_std` to `BenchmarkRunner` - removes the obsolete `add_custom_noise` replacement since noise is now handled entirely by the `Noise` object on the runner. - Kept `noise_std` argument around to ensure backwards compatibility. Differential Revision: D90597013
hvarfner
force-pushed
the
export-D90597013
branch
from
0b574ab to
a2aafe6
Compare
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Jan 14, 2026
Summary: Updates `benchmark.py` to use the new Noise module architecture: - passes `problem.noise` instead of `problem.noise_std` to `BenchmarkRunner` - removes the obsolete `add_custom_noise` replacement since noise is now handled entirely by the `Noise` object on the runner. - Kept `noise_std` argument around to ensure backwards compatibility. Differential Revision: D90597013
hvarfner
force-pushed
the
export-D90597013
branch
2 times, most recently
from
110ae85 to
34d8888
Compare
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Jan 14, 2026
Summary: Updates `benchmark.py` to use the new Noise module architecture: - passes `problem.noise` instead of `problem.noise_std` to `BenchmarkRunner` - removes the obsolete `add_custom_noise` replacement since noise is now handled entirely by the `Noise` object on the runner. - Kept `noise_std` argument around to ensure backwards compatibility. Differential Revision: D90597013
hvarfner
force-pushed
the
export-D90597013
branch
from
34d8888 to
74ce6a3
Compare
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Jan 15, 2026
Summary: Updates `benchmark.py` to use the new Noise module architecture: - passes `problem.noise` instead of `problem.noise_std` to `BenchmarkRunner` - removes the obsolete `add_custom_noise` replacement since noise is now handled entirely by the `Noise` object on the runner. - Kept `noise_std` argument around to ensure backwards compatibility. Differential Revision: D90597013 Privacy Context Container: L1307644
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Jan 15, 2026
Summary: Updates `benchmark.py` to use the new Noise module architecture: - passes `problem.noise` instead of `problem.noise_std` to `BenchmarkRunner` - removes the obsolete `add_custom_noise` replacement since noise is now handled entirely by the `Noise` object on the runner. - Kept `noise_std` argument around to ensure backwards compatibility. Differential Revision: D90597013 Privacy Context Container: L1307644
hvarfner
force-pushed
the
export-D90597013
branch
2 times, most recently
from
8c8c3c5 to
234a51c
Compare
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Jan 16, 2026
Summary: Updates `benchmark.py` to use the new Noise module architecture: - passes `problem.noise` instead of `problem.noise_std` to `BenchmarkRunner` - removes the obsolete `add_custom_noise` replacement since noise is now handled entirely by the `Noise` object on the runner. - Kept `noise_std` argument around to ensure backwards compatibility. Reviewed By: saitcakmak Differential Revision: D90597013 Privacy Context Container: L1307644
hvarfner
force-pushed
the
export-D90597013
branch
from
234a51c to
3c8805e
Compare
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Jan 16, 2026
Summary: Updates `benchmark.py` to use the new Noise module architecture: - passes `problem.noise` instead of `problem.noise_std` to `BenchmarkRunner` - removes the obsolete `add_custom_noise` replacement since noise is now handled entirely by the `Noise` object on the runner. - Kept `noise_std` argument around to ensure backwards compatibility. Reviewed By: saitcakmak Differential Revision: D90597013 Privacy Context Container: L1307644
Summary: Updates `benchmark.py` to use the new Noise module architecture: - passes `problem.noise` instead of `problem.noise_std` to `BenchmarkRunner` - removes the obsolete `add_custom_noise` replacement since noise is now handled entirely by the `Noise` object on the runner. - Kept `noise_std` argument around to ensure backwards compatibility. Reviewed By: saitcakmak Differential Revision: D90597013 Privacy Context Container: L1307644
hvarfner
force-pushed
the
export-D90597013
branch
from
3c8805e to
c258292
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Updates
benchmark.pyto use the new Noise module architecture: passesproblem.noiseinstead ofproblem.noise_stdtoBenchmarkRunner, and removes the obsoleteadd_custom_noisereplacement since noise is now handled entirely by theNoiseobject on the runner.Differential Revision: D90597013