WIP: SBIN Code Refactor #298
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added local keyword to declare variables within functions to limit their scope. * Combined the variable declarations and assignments for better readability. * Removed the `tr -d '\n'` command and replaced it with `echo -n` to write the private key to the file without a newline character. * Removed comments that are redundant or self-explanatory.
…e naming convention. Renamed the guard function to confirm to better reflect its purpose. Renamed the guard_overwrite function to confirm_overwrite for consistency. Renamed the reqdotenv function to require_dotenv for clarity. Renamed the reqenv function to require_env for consistency. Removed the comment about -y in the confirm_overwrite function as it was redundant. Improved the formatting and added comments for better readability.
This reverts commit 5e6f47f.
…eir scope. Combined the variable declarations and assignments for better readability. Removed the tr -d '\n' command and replaced it with echo -n to write the private key to the file without a newline character. Removed comments that are redundant or self-explanatory.
Removed unnecessary comments and debugging statements for a cleaner code Added descriptive comments for better understanding Used consistent indentation for improved readability Used double quotes around variable expansions for better robustness Reorganized the code to improve flow and readability
Created a function cleanup_file to handle the repetitive code for removing files. Improved variable names for readability (e.g., SBIN to SCRIPT_DIR). Removed debug statements to improve code cleanliness. Added comments for clarity and readability. Standardized variable names (e.g., SBIN to SCRIPT_DIR). Used double quotes around variables to handle spaces and special characters in file paths. Improved indentation and formatting for better readability.
…ge readability, and removed unnecessary debugging statements for better code clarity.
…ed readability by organizing the code and removing unnecessary echo statements.
…e debugging statement, and improved the readability of the code by reformatting the comments and aligning the code blocks.
…oved readability. Removed debugging statements and provided more informative output for usage. Set default values for variables and handled command line arguments more clearly. Organized the code in a more structured and readable manner.
Removed the debugging statement "set -ex" for improved readability. Added comments to explain the purpose of each section of the script. Utilized more descriptive environment variable names for clarity. Reorganized the script for better structure and readability.
Renamed JWT to JWT_SECRET for clarity. Removed unnecessary variable reassignment. Removed debugging statement. Improved variable naming for better readability.
…ase, removed debugging statements, improved readability by using descriptive variable names, and made the code more consistent.
…improved readability by following common shell scripting conventions.
…ncy. Removed the unnecessary echo statement for better readability. Improved variable names for better readability and maintainability. Standardized the variable name for the lock file.
…g statements, improving readability, and more. Explain what you did to clean it up in a short and concise way.
Removed unnecessary cd command by directly assigning the result to SBIN_DIR. Standardized the variable names for better readability. Removed debugging statements. Escaped the $FLAGS[@] inside the echo command to prevent premature expansion.
Removed debugging statements Added comments for clarity Standardized the flag parsing section Made the script more readable and maintainable
Removed debugging statements for better readability. Improved readability by formatting the code with line breaks and indentation. Consolidated the flags into an array for better organization.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor and clean up of SBIN. The scripts have been hacked on (by me) so I wanted to clean them up. This will make a fresh start for the service health checks I need to complete for K8.