minor symfony#58188 Don't use is_resource() on non-streams (nicolas-g…

…rekas)

This PR was merged into the 5.4 branch.

Discussion
----------

Don't use is_resource() on non-streams

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

Prepares for https://wiki.php.net/rfc/resource_to_object_conversion

Commits
-------

b12b7a0 Don't use is_resource() on non-streams

src/Symfony/Component/Console/Terminal.php

@@ -158,8 +158,7 @@ private static function readFromProcess(string $command): ?string
 
         $cp = \function_exists('sapi_windows_cp_set') ? sapi_windows_cp_get() : 0;
 
-        $process = proc_open($command, $descriptorspec, $pipes, null, null, ['suppress_errors' => true]);
-        if (!\is_resource($process)) {
+        if (!$process = proc_open($command, $descriptorspec, $pipes, null, null, ['suppress_errors' => true])) {
             return null;
         }
 

src/Symfony/Component/HttpKernel/Log/Logger.php

@@ -67,7 +67,7 @@ public function __construct(?string $minLevel = null, $output = null, ?callable
 
         $this->minLevelIndex = self::LEVELS[$minLevel];
         $this->formatter = $formatter ?: [$this, 'format'];
-        if ($output && false === $this->handle = \is_resource($output) ? $output : @fopen($output, 'a')) {
+        if ($output && false === $this->handle = \is_string($output) ? @fopen($output, 'a') : $output) {
             throw new InvalidArgumentException(sprintf('Unable to open "%s".', $output));
         }
     }

src/Symfony/Component/Process/Process.php

@@ -352,7 +352,7 @@ public function start(?callable $callback = null, array $env = [])
 
         $this->process = @proc_open($commandline, $descriptors, $this->processPipes->pipes, $this->cwd, $envPairs, $this->options);
 
-        if (!\is_resource($this->process)) {
+        if (!$this->process) {
             throw new RuntimeException('Unable to launch a new process.');
         }
         $this->status = self::STATUS_STARTED;
@@ -1456,8 +1456,9 @@ private function readPipes(bool $blocking, bool $close)
     private function close(): int
     {
         $this->processPipes->close();
-        if (\is_resource($this->process)) {
+        if ($this->process) {
             proc_close($this->process);
+            $this->process = null;
         }
         $this->exitcode = $this->processInformation['exitcode'];
         $this->status = self::STATUS_TERMINATED;