Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix usage of generic variable #287

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rajzik
Copy link
Contributor

@rajzik rajzik commented Feb 7, 2025

After update to latest version I've regenerated context and found out that generic variable isn't used.

@rajzik
Copy link
Contributor Author

rajzik commented Feb 7, 2025

This is not ready, with this change typescript will throw errors.

@fabien0102
Copy link
Owner

Yeah, this type is quite tricky somehow, this is the underline type:

type Enabled<TQueryFnData = unknown, TError = DefaultError, TData = TQueryFnData, TQueryKey extends QueryKey = QueryKey> = boolean | ((query: Query<TQueryFnData, TError, TData, TQueryKey>) => boolean)

Since TData = TQueryFnData the best I found, so far, is the current version, but I’m also not 100% happy about it ^^

@fabien0102 fabien0102 marked this pull request as draft February 8, 2025 15:30
@fabien0102
Copy link
Owner

I’m converting this one to "draft" to avoid confusion ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants