DRAFT PR: adding interpolation to mdl animations #2314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwestphal
reviewed
Jun 19, 2025
| //interpolation | ||
| if (frameAIndex != frameBIndex) | ||
| { | ||
| vtkNew<vtkInterpolateDataSetAttributes> interpolator; |
There was a problem hiding this comment.
vtkNew is a RAII mechanism, which means interpolator is deallocated when you leave the scope, which means the dataset is deleted before you display it
There was a problem hiding this comment.
You need to store the Interpolator as a member of the vtkF3DQuakeMDLImporter so it keeps on living when you leave this method.
|
Need any help moving forward @The-Lennzer ? |
1 similar comment
|
Need any help moving forward @The-Lennzer ? |
mwestphal
reviewed
Jul 25, 2025
Comment on lines
+509
to
+510
| iPtr->SetInputData(0, frameA); | ||
| iPtr->SetInputData(1, frameB); |
There was a problem hiding this comment.
Suggested change
| iPtr->SetInputData(0, frameA); | |
| iPtr->SetInputData(1, frameB); | |
| iPtr->AddInputData(frameA); | |
| iPtr->AddInputData(frameB); |
|
Need any help moving forward @The-Lennzer ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Changed File:
vtkF3DQuakeMDLImporter.cxxtimeValueto find two adjacent frames instead of just the previous FramevtkNew<vtkInterpolateDataSetAttributes>Issue ticket number and link if any
#2138
This is a work-in-progress draft PR to fix issues in interpolation logic