Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Github Integration using Github Actions #528

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Better Github Integration using Github Actions #528

wants to merge 1 commit into from

Conversation

Plopix
Copy link
Contributor

@Plopix Plopix commented Apr 7, 2020

Motivation

I have done this experiment, for 3 reasons:

  • Github Actions is free for the community and faster than Travis, and I think that's the future.
  • to simplify all the docker "things" this repository contains
  • in order to simplify the .env later. Because it contains too much configuration unrelated to the application

In Bonus, I figured that it would be awesome to actually test eZ Platform with Varnish and Redis through eZ Launchpad!

That would make so much sense.

Then I have initiated it.

I took some liberties for now:

  • No more Nginx for testing but Symfony Server: As Prod mode will be tested through eZ Launchpad.

Questions

  • Maybe eZ Launchpad should use the vhost.sh script. (unsure)
  • Maybe eZ Launchpad should use the varnish.vcl coming from http-cache bundle. (this one I am pretty sure)

Todos

  • Make tests working
  • Trick eZ Launchpad to ez create instead of init
  • Trick eZ Launchpad for Solr to run.
  • Make tests over Varnish working
  • Clean .travis folder
  • Remove fail-fast: false

What do you think? what is all that stuff regarding Docker in the repo?
I am sure it is all very interesting and that could benefit eZ Launchpad and vice-versa.
But I have never ever used what you have in the docker folder, where do you use it? internally?

I'll continue on making test works tonight,

Ping @andrerom, @bdunogier, @lserwatka @SylvainGuittard

https://github.com/Plopix/ezplatform/actions

Let me know!

@andrerom
Copy link
Contributor

andrerom commented Apr 7, 2020

You imply a lot of questions here on future use of Launchpad and use of docker, so in general I think:

  1. eZ need to take over responsibility of launchpad and change it to our needs, or come up with something different (from scratch, on top of symfony cli, or or something like it) to cover the local development scenario, especially to streamline eZ Platform Cloud development needs
  2. We do plan to move to Symfony Flex, that will imply some re-thinking on how we approach env, docker and in general the organization of this meta repo as well.

Up to Engineering here, but I would guess we in general are +1 on looking toward Github Actions, but maybe we should not mix launchpad into that question at first?

Aslo if we move to Github Actions, we'd likely want to do it across all branches and repos.

Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, we need to explore this deeper before we decide to move this direction. It's definitely worth looking into (cc @mnocon).

The main issue I see now is that we use enterprise version of Travis which gives us better support and job debugging capabilities. Not sure if GH actions offer this on the same level w/o a need for plan upgrade.

But really reviewed because of other things ;)

Comment on lines +1 to +12
| Q | A
| ------------- | ---
| Branch? | master / x.y.z
| Bug fix? | yes/no
| New feature? | yes/no <!-- don't forget updating docs/CHANGELOG.md files -->
| BC breaks? | yes/no
| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->

<!--
- Please fill in this template according to the PR you're about to submit.
- Replace this comment by a description of what your PR is solving.
-->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're aiming to unify it accross all the repositories. The latest version I've come up with is here, but still requires some debate probably, since I've pushed this during the 3.0 release rush.

Comment on lines +1 to +14
| Q | A
| ---------------- | -----
| Bug report? | yes/no
| Feature request? | yes/no
| BC Break report? | yes/no
| RFC? | yes/no
| Version | x.y.z
| Environment | Linux/Mac/Windows


<!--
- Please fill in this template according to your issue.
- And replace this comment by the description of your issue.
-->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not relevant for us, we don't support Issues (see that the tab is missing). All the issues should be reported in JIRA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants