Warn users on mainnet with --development

because --development crashes the node more often.

Author: Yoichi Hirai

raiden/ui/checks.py

@@ -152,6 +152,20 @@ def check_ethereum_network_id(given_network_id: ChainID, web3: Web3) -> None:
         sys.exit(1)
 
 
+def check_raiden_environment(network_id: ChainID, environment_type: Environment) -> None:
+    warn = (  # mainnet --development is only for tests
+        network_id == 1 and environment_type == Environment.DEVELOPMENT
+    )
+    if warn:
+        click.secho(
+            f"The chosen network ({ID_TO_NETWORKNAME[network_id]}) is not a testnet, "
+            f'but the "development" environment was selected.\n'
+            f"This crashes the node often. Please start again with a safe environment setting "
+            f"(--environment production).",
+            fg="red",
+        )
+
+
 def check_smart_contract_addresses(
     environment_type: Environment,
     node_network_id: ChainID,

raiden/ui/startup.py

@@ -13,7 +13,11 @@
 from raiden.network.proxies.token_network_registry import TokenNetworkRegistry
 from raiden.network.proxies.user_deposit import UserDeposit
 from raiden.settings import RAIDEN_CONTRACT_VERSION
-from raiden.ui.checks import check_pfs_configuration, check_smart_contract_addresses
+from raiden.ui.checks import (
+    check_pfs_configuration,
+    check_raiden_environment,
+    check_smart_contract_addresses,
+)
 from raiden.utils.typing import Address, ChainID, TokenNetworkRegistryAddress
 from raiden_contracts.constants import (
     CONTRACT_SECRET_REGISTRY,
@@ -46,6 +50,10 @@ def setup_contracts_or_exit(config: Dict[str, Any], network_id: ChainID) -> Dict
     If an invalid combination of network id and environment type is provided, exits
     the program with an error
     """
+    environment_type = config["environment_type"]
+
+    check_raiden_environment(network_id, environment_type)
+
     contracts: Dict[str, Any] = dict()
     contracts_version = RAIDEN_CONTRACT_VERSION